diff options
author | Johannes Berg <johannes.berg@intel.com> | 2012-07-12 16:19:48 -0400 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2012-07-13 10:16:11 -0400 |
commit | 4290cb4bf212112e3d6f860e25f000ca8a1ca6a4 (patch) | |
tree | b6dda8955a4e199c318860ffa01dc9b2ea417905 /include | |
parent | 5b7ccaf3fc7446e42b83a77fd7aa7ad92850acdd (diff) |
cfg80211: reduce monitor interface tracking
Revert commit b78e8ceac23655e1e06b30aa95ab11742d1ac7c0
("cfg80211: track monitor channel") and remove the
set_monitor_enabled() callback.
Due to the tracking happening in NETDEV_PRE_UP, it had
introduced bugs because the monitor interface callback
would be called before the device was started. It looks
like there's no way to fix this, and using NETDEV_PRE_UP
is broken anyway (since there's no NETDEV_UP_FAIL), so
remove all that code, track interfaces in NETDEV_UP and
also stop tracking the monitor channel in cfg80211.
This mostly reverts to before the tracking, except that
we keep the interface count tracking so that setting the
monitor channel can be rejected properly.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'include')
-rw-r--r-- | include/net/cfg80211.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index 8115d68eb603..0245208c2978 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h | |||
@@ -1504,8 +1504,6 @@ struct cfg80211_gtk_rekey_data { | |||
1504 | * interfaces are active this callback should reject the configuration. | 1504 | * interfaces are active this callback should reject the configuration. |
1505 | * If no interfaces are active or the device is down, the channel should | 1505 | * If no interfaces are active or the device is down, the channel should |
1506 | * be stored for when a monitor interface becomes active. | 1506 | * be stored for when a monitor interface becomes active. |
1507 | * @set_monitor_enabled: Notify driver that there are only monitor | ||
1508 | * interfaces running. | ||
1509 | * | 1507 | * |
1510 | * @scan: Request to do a scan. If returning zero, the scan request is given | 1508 | * @scan: Request to do a scan. If returning zero, the scan request is given |
1511 | * the driver, and will be valid until passed to cfg80211_scan_done(). | 1509 | * the driver, and will be valid until passed to cfg80211_scan_done(). |
@@ -1824,8 +1822,6 @@ struct cfg80211_ops { | |||
1824 | void (*get_et_strings)(struct wiphy *wiphy, struct net_device *dev, | 1822 | void (*get_et_strings)(struct wiphy *wiphy, struct net_device *dev, |
1825 | u32 sset, u8 *data); | 1823 | u32 sset, u8 *data); |
1826 | 1824 | ||
1827 | void (*set_monitor_enabled)(struct wiphy *wiphy, bool enabled); | ||
1828 | |||
1829 | struct ieee80211_channel * | 1825 | struct ieee80211_channel * |
1830 | (*get_channel)(struct wiphy *wiphy, | 1826 | (*get_channel)(struct wiphy *wiphy, |
1831 | struct wireless_dev *wdev, | 1827 | struct wireless_dev *wdev, |