aboutsummaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorPaul Clements <paul.clements@steeleye.com>2007-10-17 02:27:37 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-10-17 11:42:55 -0400
commit7fdfd4065c264bddd2d9277470a6a99d34e01bef (patch)
treee2423a0338bf5d48f24bca1091e3069508f45f01 /include
parent4b86a872561ad052bdc6f092a06807822d26beb1 (diff)
NBD: allow hung network I/O to be cancelled
Allow NBD I/O to be cancelled when a network outage occurs. Previously, I/O would just hang, and if enough I/O was hung in nbd, the system (at least user-level) would completely hang until a TCP timeout (default, 15 minutes) occurred. The patch introduces a new ioctl NBD_SET_TIMEOUT that allows a transmit timeout value (in seconds) to be specified. Any network send that exceeds the timeout will be cancelled and the nbd connection will be shut down. I've tested with various timeout values and 6 seconds seems to be a good choice for the timeout. If the NBD_SET_TIMEOUT ioctl is not called, you get the old (I/O hang) behavior. Signed-off-by: Paul Clements <paul.clements@steeleye.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include')
-rw-r--r--include/linux/nbd.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/include/linux/nbd.h b/include/linux/nbd.h
index 0f3e69302540..cc2b47240a8f 100644
--- a/include/linux/nbd.h
+++ b/include/linux/nbd.h
@@ -26,6 +26,7 @@
26#define NBD_PRINT_DEBUG _IO( 0xab, 6 ) 26#define NBD_PRINT_DEBUG _IO( 0xab, 6 )
27#define NBD_SET_SIZE_BLOCKS _IO( 0xab, 7 ) 27#define NBD_SET_SIZE_BLOCKS _IO( 0xab, 7 )
28#define NBD_DISCONNECT _IO( 0xab, 8 ) 28#define NBD_DISCONNECT _IO( 0xab, 8 )
29#define NBD_SET_TIMEOUT _IO( 0xab, 9 )
29 30
30enum { 31enum {
31 NBD_CMD_READ = 0, 32 NBD_CMD_READ = 0,
@@ -65,6 +66,7 @@ struct nbd_device {
65 int blksize; 66 int blksize;
66 u64 bytesize; 67 u64 bytesize;
67 pid_t pid; /* pid of nbd-client, if attached */ 68 pid_t pid; /* pid of nbd-client, if attached */
69 int xmit_timeout;
68}; 70};
69 71
70#endif 72#endif