diff options
author | Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> | 2009-08-25 02:06:22 -0400 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2009-08-26 00:32:09 -0400 |
commit | 5ac35daa9343936038a3c9c4f4d6d3fe6a2a7bd8 (patch) | |
tree | 0810db04bd8ad675aee30681576903e393e9d4c6 /include | |
parent | 5079f3261ffd7fe4a537679af695f2328943a245 (diff) |
tracing/events: fix the include file dependencies
The TRACE_EVENT depends on the include/linux/tracepoint.h first
and include/trace/ftrace.h later, if we include the ftrace.h early,
a building error will occur.
Both define TRACE_EVENT in trace_a.h and trace_b.h, if we include
those in .c file, like this:
#define CREATE_TRACE_POINTS
include <trace/events/trace_a.h>
include <trace/events/trace_b.h>
The above will not work, because the TRACE_EVENT was re-defined by
the previous .h file.
Reported-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
LKML-Reference: <4A937F5E.3020802@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'include')
-rw-r--r-- | include/linux/tracepoint.h | 3 | ||||
-rw-r--r-- | include/trace/define_trace.h | 1 |
2 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h index 5984ed04c03b..81709854f7ab 100644 --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h | |||
@@ -180,6 +180,7 @@ static inline void tracepoint_synchronize_unregister(void) | |||
180 | } | 180 | } |
181 | 181 | ||
182 | #define PARAMS(args...) args | 182 | #define PARAMS(args...) args |
183 | #endif | ||
183 | 184 | ||
184 | #ifndef TRACE_EVENT | 185 | #ifndef TRACE_EVENT |
185 | /* | 186 | /* |
@@ -287,5 +288,3 @@ static inline void tracepoint_synchronize_unregister(void) | |||
287 | #define TRACE_EVENT(name, proto, args, struct, assign, print) \ | 288 | #define TRACE_EVENT(name, proto, args, struct, assign, print) \ |
288 | DECLARE_TRACE(name, PARAMS(proto), PARAMS(args)) | 289 | DECLARE_TRACE(name, PARAMS(proto), PARAMS(args)) |
289 | #endif | 290 | #endif |
290 | |||
291 | #endif | ||
diff --git a/include/trace/define_trace.h b/include/trace/define_trace.h index f7a7ae1e8f90..cd150b9d8e32 100644 --- a/include/trace/define_trace.h +++ b/include/trace/define_trace.h | |||
@@ -56,6 +56,7 @@ | |||
56 | #include <trace/ftrace.h> | 56 | #include <trace/ftrace.h> |
57 | #endif | 57 | #endif |
58 | 58 | ||
59 | #undef TRACE_EVENT | ||
59 | #undef TRACE_HEADER_MULTI_READ | 60 | #undef TRACE_HEADER_MULTI_READ |
60 | 61 | ||
61 | /* Only undef what we defined in this file */ | 62 | /* Only undef what we defined in this file */ |