diff options
author | Milton Miller <miltonm@bga.com> | 2008-07-10 17:29:37 -0400 |
---|---|---|
committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2008-10-20 13:48:34 -0400 |
commit | edbc25caaa492a82e19baa915f1f6b0a0db6554d (patch) | |
tree | 967dbd4f8d35fd8532a612fef55691586b831965 /include | |
parent | 7d67474e506598fe26e0c262acf02132dc730517 (diff) |
PCI: remove dynids.use_driver_data
The driver flag dynids.use_driver_data is almost consistently not set,
and causes more problems than it solves. It was initially intended as a
flag to indicate whether a driver's usage of driver_data had been
carefully inspected and was ready for values from userspace. That audit
was never done, so most drivers just get a 0 for driver_data when new
IDs are added from userspace via sysfs. So remove the flag, allowing
drivers to see the data directly (a followon patch validates the passed
driver_data value against what the drivers expect).
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'include')
-rw-r--r-- | include/linux/pci.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/pci.h b/include/linux/pci.h index acf8f24037cd..c989f58d09bf 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h | |||
@@ -347,7 +347,6 @@ struct pci_bus_region { | |||
347 | struct pci_dynids { | 347 | struct pci_dynids { |
348 | spinlock_t lock; /* protects list, index */ | 348 | spinlock_t lock; /* protects list, index */ |
349 | struct list_head list; /* for IDs added at runtime */ | 349 | struct list_head list; /* for IDs added at runtime */ |
350 | unsigned int use_driver_data:1; /* pci_device_id->driver_data is used */ | ||
351 | }; | 350 | }; |
352 | 351 | ||
353 | /* ---------------------------------------------------------------- */ | 352 | /* ---------------------------------------------------------------- */ |