diff options
author | Rafael J. Wysocki <rjw@sisk.pl> | 2010-06-30 23:07:20 -0400 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2010-07-06 22:34:27 -0400 |
commit | 546eb57695875712f676e5f729159b0779f1c0af (patch) | |
tree | 1f8da8d567b75fa1fb821b059f682d4bae92ce8e /include | |
parent | 3bd741bd0dfcc1845ae6892baa5192c91addc84c (diff) |
ACPICA: Drop acpi_set_gpe
The acpi_set_gpe() function is a little awkward, because it doesn't
really work as advertised in the "disable" case. Namely, if a GPE
has been enabled with acpi_enable_gpe() and triggered a notification
to occur, and if acpi_set_gpe() is used to disable it before
acpi_ev_asynch_enable_gpe() runs, the GPE will be immediately enabled
by the latter as though the acpi_set_gpe() had no effect.
Thus, since it's been possible to make all of its callers use
alternative operations to disable or enable GPEs, acpi_set_gpe() can
be dropped.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'include')
-rw-r--r-- | include/acpi/acpixf.h | 2 | ||||
-rw-r--r-- | include/acpi/actypes.h | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h index 354d785e80cb..e0a53e4616df 100644 --- a/include/acpi/acpixf.h +++ b/include/acpi/acpixf.h | |||
@@ -282,8 +282,6 @@ acpi_status acpi_get_event_status(u32 event, acpi_event_status * event_status); | |||
282 | /* | 282 | /* |
283 | * GPE Interfaces | 283 | * GPE Interfaces |
284 | */ | 284 | */ |
285 | acpi_status acpi_set_gpe(acpi_handle gpe_device, u32 gpe_number, u8 action); | ||
286 | |||
287 | acpi_status acpi_enable_gpe(acpi_handle gpe_device, u32 gpe_number); | 285 | acpi_status acpi_enable_gpe(acpi_handle gpe_device, u32 gpe_number); |
288 | 286 | ||
289 | acpi_status acpi_disable_gpe(acpi_handle gpe_device, u32 gpe_number); | 287 | acpi_status acpi_disable_gpe(acpi_handle gpe_device, u32 gpe_number); |
diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h index a42513ded3a4..5db8f472fec9 100644 --- a/include/acpi/actypes.h +++ b/include/acpi/actypes.h | |||
@@ -663,7 +663,7 @@ typedef u32 acpi_event_status; | |||
663 | #define ACPI_GPE_MAX 0xFF | 663 | #define ACPI_GPE_MAX 0xFF |
664 | #define ACPI_NUM_GPE 256 | 664 | #define ACPI_NUM_GPE 256 |
665 | 665 | ||
666 | /* Actions for acpi_set_gpe, acpi_gpe_wakeup, acpi_hw_low_set_gpe */ | 666 | /* Actions for acpi_gpe_wakeup, acpi_hw_low_set_gpe */ |
667 | 667 | ||
668 | #define ACPI_GPE_ENABLE 0 | 668 | #define ACPI_GPE_ENABLE 0 |
669 | #define ACPI_GPE_DISABLE 1 | 669 | #define ACPI_GPE_DISABLE 1 |