diff options
author | Vlad Yasevich <vladislav.yasevich@hp.com> | 2007-10-25 21:54:46 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2007-10-25 21:54:46 -0400 |
commit | fee9dee730a40f671c1972a324ed54f0d68523e1 (patch) | |
tree | 4a688264696a3cfdf7312e92b52ac4794197a7a5 /include | |
parent | 41fb285430e9cb57da624d838afef7b2fc67e276 (diff) |
[UDP]: Make use of inet_iif() when doing socket lookups.
UDP currently uses skb->dev->ifindex which may provide the wrong
information when the socket bound to a specific interface.
This patch makes inet_iif() accessible to UDP and makes UDP use it.
The scenario we are trying to fix is when a client is running on
the same system and the server and both client and server bind to
a non-loopback device.
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Acked-by: David L Stevens <dlstevens@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
-rw-r--r-- | include/net/inet_hashtables.h | 6 | ||||
-rw-r--r-- | include/net/inet_sock.h | 7 |
2 files changed, 7 insertions, 6 deletions
diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h index 8228b57eb18f..4427dcd1e53a 100644 --- a/include/net/inet_hashtables.h +++ b/include/net/inet_hashtables.h | |||
@@ -26,7 +26,6 @@ | |||
26 | 26 | ||
27 | #include <net/inet_connection_sock.h> | 27 | #include <net/inet_connection_sock.h> |
28 | #include <net/inet_sock.h> | 28 | #include <net/inet_sock.h> |
29 | #include <net/route.h> | ||
30 | #include <net/sock.h> | 29 | #include <net/sock.h> |
31 | #include <net/tcp_states.h> | 30 | #include <net/tcp_states.h> |
32 | 31 | ||
@@ -266,11 +265,6 @@ out: | |||
266 | wake_up(&hashinfo->lhash_wait); | 265 | wake_up(&hashinfo->lhash_wait); |
267 | } | 266 | } |
268 | 267 | ||
269 | static inline int inet_iif(const struct sk_buff *skb) | ||
270 | { | ||
271 | return ((struct rtable *)skb->dst)->rt_iif; | ||
272 | } | ||
273 | |||
274 | extern struct sock *__inet_lookup_listener(struct inet_hashinfo *hashinfo, | 268 | extern struct sock *__inet_lookup_listener(struct inet_hashinfo *hashinfo, |
275 | const __be32 daddr, | 269 | const __be32 daddr, |
276 | const unsigned short hnum, | 270 | const unsigned short hnum, |
diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h index 62daf214931f..70013c5f4e59 100644 --- a/include/net/inet_sock.h +++ b/include/net/inet_sock.h | |||
@@ -24,6 +24,7 @@ | |||
24 | #include <net/flow.h> | 24 | #include <net/flow.h> |
25 | #include <net/sock.h> | 25 | #include <net/sock.h> |
26 | #include <net/request_sock.h> | 26 | #include <net/request_sock.h> |
27 | #include <net/route.h> | ||
27 | 28 | ||
28 | /** struct ip_options - IP Options | 29 | /** struct ip_options - IP Options |
29 | * | 30 | * |
@@ -190,4 +191,10 @@ static inline int inet_sk_ehashfn(const struct sock *sk) | |||
190 | return inet_ehashfn(laddr, lport, faddr, fport); | 191 | return inet_ehashfn(laddr, lport, faddr, fport); |
191 | } | 192 | } |
192 | 193 | ||
194 | |||
195 | static inline int inet_iif(const struct sk_buff *skb) | ||
196 | { | ||
197 | return ((struct rtable *)skb->dst)->rt_iif; | ||
198 | } | ||
199 | |||
193 | #endif /* _INET_SOCK_H */ | 200 | #endif /* _INET_SOCK_H */ |