diff options
author | David Howells <dhowells@redhat.com> | 2009-04-03 11:42:35 -0400 |
---|---|---|
committer | David Howells <dhowells@redhat.com> | 2009-04-03 11:42:35 -0400 |
commit | 03fb3d2af96c2783c3a5bc03f3d984cf422f0e69 (patch) | |
tree | 6618f82f8be26ba2c7ac38d6e6e16befc8e1140f /include | |
parent | 8f0aa2f25b31ba27db84259141e52ee6ec0d2820 (diff) |
FS-Cache: Release page->private after failed readahead
The attached patch causes read_cache_pages() to release page-private data on a
page for which add_to_page_cache() fails. If the filler function fails, then
the problematic page is left attached to the pagecache (with appropriate flags
set, one presumes) and the remaining to-be-attached pages are invalidated and
discarded. This permits pages with caching references associated with them to
be cleaned up.
The invalidatepage() address space op is called (indirectly) to do the honours.
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Steve Dickson <steved@redhat.com>
Acked-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Tested-by: Daire Byrne <Daire.Byrne@framestore.com>
Diffstat (limited to 'include')
-rw-r--r-- | include/linux/page-flags.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 61df1779b2a5..9d99e7471ade 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h | |||
@@ -182,7 +182,7 @@ static inline int TestClearPage##uname(struct page *page) { return 0; } | |||
182 | 182 | ||
183 | struct page; /* forward declaration */ | 183 | struct page; /* forward declaration */ |
184 | 184 | ||
185 | TESTPAGEFLAG(Locked, locked) | 185 | TESTPAGEFLAG(Locked, locked) TESTSETFLAG(Locked, locked) |
186 | PAGEFLAG(Error, error) | 186 | PAGEFLAG(Error, error) |
187 | PAGEFLAG(Referenced, referenced) TESTCLEARFLAG(Referenced, referenced) | 187 | PAGEFLAG(Referenced, referenced) TESTCLEARFLAG(Referenced, referenced) |
188 | PAGEFLAG(Dirty, dirty) TESTSCFLAG(Dirty, dirty) __CLEARPAGEFLAG(Dirty, dirty) | 188 | PAGEFLAG(Dirty, dirty) TESTSCFLAG(Dirty, dirty) __CLEARPAGEFLAG(Dirty, dirty) |