aboutsummaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorPavel Emelianov <xemul@openvz.org>2007-10-19 02:39:46 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-10-19 14:53:37 -0400
commita47afb0f9d794d525a372c8d69902147cc88222a (patch)
tree7bd67280e2edc1c3b1803d4a93bee794088e9342 /include
parent858d72ead4864da0fb0b89b919524125ce998e27 (diff)
pid namespaces: round up the API
The set of functions process_session, task_session, process_group and task_pgrp is confusing, as the names can be mixed with each other when looking at the code for a long time. The proposals are to * equip the functions that return the integer with _nr suffix to represent that fact, * and to make all functions work with task (not process) by making the common prefix of the same name. For monotony the routines signal_session() and set_signal_session() are replaced with task_session_nr() and set_task_session(), especially since they are only used with the explicit task->signal dereference. Signed-off-by: Pavel Emelianov <xemul@openvz.org> Acked-by: Serge E. Hallyn <serue@us.ibm.com> Cc: Kirill Korotaev <dev@openvz.org> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Cedric Le Goater <clg@fr.ibm.com> Cc: Herbert Poetzl <herbert@13thfloor.at> Cc: Sukadev Bhattiprolu <sukadev@us.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include')
-rw-r--r--include/linux/sched.h15
1 files changed, 5 insertions, 10 deletions
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 93a55f2e5ef6..df6049e5e8bf 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1188,24 +1188,19 @@ static inline int rt_task(struct task_struct *p)
1188 return rt_prio(p->prio); 1188 return rt_prio(p->prio);
1189} 1189}
1190 1190
1191static inline pid_t process_group(struct task_struct *tsk) 1191static inline pid_t task_pgrp_nr(struct task_struct *tsk)
1192{ 1192{
1193 return tsk->signal->pgrp; 1193 return tsk->signal->pgrp;
1194} 1194}
1195 1195
1196static inline pid_t signal_session(struct signal_struct *sig) 1196static inline pid_t task_session_nr(struct task_struct *tsk)
1197{ 1197{
1198 return sig->__session; 1198 return tsk->signal->__session;
1199} 1199}
1200 1200
1201static inline pid_t process_session(struct task_struct *tsk) 1201static inline void set_task_session(struct task_struct *tsk, pid_t session)
1202{ 1202{
1203 return signal_session(tsk->signal); 1203 tsk->signal->__session = session;
1204}
1205
1206static inline void set_signal_session(struct signal_struct *sig, pid_t session)
1207{
1208 sig->__session = session;
1209} 1204}
1210 1205
1211static inline struct pid *task_pid(struct task_struct *task) 1206static inline struct pid *task_pid(struct task_struct *task)