diff options
author | Martin K. Petersen <martin.petersen@oracle.com> | 2012-04-14 23:01:28 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-04-15 14:08:53 -0400 |
commit | 919f797a4c9c22ff5ec059744dba364dc600ece2 (patch) | |
tree | 6f2183e84c2bcfdc6eebed82319a4a21b871bdea /include | |
parent | bfecc60d8f6715ec6b38aa29c4f5a3570415dae0 (diff) |
SCSI: Fix error handling when no ULD is attached
Commit 18a4d0a22ed6 ("[SCSI] Handle disk devices which can not process
medium access commands") introduced a bug in which we would attempt to
dereference the scsi driver even when the device had no ULD attached.
Ensure that a driver is registered and make the driver accessor function
more resilient to errors during device discovery.
Reported-by: Elric Fu <elricfu1@gmail.com>
Reported-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include')
-rw-r--r-- | include/scsi/scsi_cmnd.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h index 377df4a28512..1e1198546c72 100644 --- a/include/scsi/scsi_cmnd.h +++ b/include/scsi/scsi_cmnd.h | |||
@@ -134,6 +134,9 @@ struct scsi_cmnd { | |||
134 | 134 | ||
135 | static inline struct scsi_driver *scsi_cmd_to_driver(struct scsi_cmnd *cmd) | 135 | static inline struct scsi_driver *scsi_cmd_to_driver(struct scsi_cmnd *cmd) |
136 | { | 136 | { |
137 | if (!cmd->request->rq_disk) | ||
138 | return NULL; | ||
139 | |||
137 | return *(struct scsi_driver **)cmd->request->rq_disk->private_data; | 140 | return *(struct scsi_driver **)cmd->request->rq_disk->private_data; |
138 | } | 141 | } |
139 | 142 | ||