aboutsummaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorCorey Minyard <cminyard@mvista.com>2008-04-29 04:01:02 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2008-04-29 11:06:14 -0400
commitbda4c30aa6f7dc1483f39ea1dfe37bcab8a96207 (patch)
tree760c538139c5b41ef54a27d62e5a8a1b01cf1c60 /include
parent4ea18425436e7c72716b7f8d314775f399821195 (diff)
ipmi: run to completion fixes
The "run_to_completion" mode was somewhat broken. Locks need to be avoided in run_to_completion mode, and it shouldn't be used by normal users, just internally for panic situations. This patch removes locks in run_to_completion mode and removes the user call for setting the mode. The only user was the poweroff code, but it was easily converted to use the polling interface. [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Corey Minyard <cminyard@mvista.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include')
-rw-r--r--include/linux/ipmi.h11
1 files changed, 2 insertions, 9 deletions
diff --git a/include/linux/ipmi.h b/include/linux/ipmi.h
index c5bd28b69aec..1144b32f5310 100644
--- a/include/linux/ipmi.h
+++ b/include/linux/ipmi.h
@@ -368,9 +368,8 @@ int ipmi_request_supply_msgs(ipmi_user_t user,
368 * Poll the IPMI interface for the user. This causes the IPMI code to 368 * Poll the IPMI interface for the user. This causes the IPMI code to
369 * do an immediate check for information from the driver and handle 369 * do an immediate check for information from the driver and handle
370 * anything that is immediately pending. This will not block in any 370 * anything that is immediately pending. This will not block in any
371 * way. This is useful if you need to implement polling from the user 371 * way. This is useful if you need to spin waiting for something to
372 * for things like modifying the watchdog timeout when a panic occurs 372 * happen in the IPMI driver.
373 * or disabling the watchdog timer on a reboot.
374 */ 373 */
375void ipmi_poll_interface(ipmi_user_t user); 374void ipmi_poll_interface(ipmi_user_t user);
376 375
@@ -422,12 +421,6 @@ int ipmi_get_maintenance_mode(ipmi_user_t user);
422int ipmi_set_maintenance_mode(ipmi_user_t user, int mode); 421int ipmi_set_maintenance_mode(ipmi_user_t user, int mode);
423 422
424/* 423/*
425 * Allow run-to-completion mode to be set for the interface of
426 * a specific user.
427 */
428void ipmi_user_set_run_to_completion(ipmi_user_t user, int val);
429
430/*
431 * When the user is created, it will not receive IPMI events by 424 * When the user is created, it will not receive IPMI events by
432 * default. The user must set this to TRUE to get incoming events. 425 * default. The user must set this to TRUE to get incoming events.
433 * The first user that sets this to TRUE will receive all events that 426 * The first user that sets this to TRUE will receive all events that