diff options
author | Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> | 2010-09-08 22:48:01 -0400 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2010-09-10 11:07:41 -0400 |
commit | dec6aa49abf73b061b631163cb1e1d803a614d24 (patch) | |
tree | 6e4e8010c0ad0bb1eb005364e76fb1bf475cc753 /include/video | |
parent | f4363b7d88e99497e4241397efee09b106d802c4 (diff) |
fbdev: sh_mobile_hdmi: modify flags name to more specific
This patch solve below report from Guennadi
1)
> +/* Audio source select */
> +#define HDMI_SRC_MASK (0xF << 0)
> +#define HDMI_SRC_I2S (0 << 0) /* default */
> +#define HDMI_SRC_SPDIF (1 << 0)
> +#define HDMI_SRC_DSD (2 << 0)
> +#define HDMI_SRC_HBR (3 << 0)
I would be more specific with these macro names, i.e., include "AUDIO" or
"SND" or something similar in them, e.g., HDMI_AUDIO_SRC_I2S.
2)
> + case HDMI_SRC_I2S:
> + data = (0x0 << 3);
> + break;
> + case HDMI_SRC_SPDIF:
> + data = (0x1 << 3);
> + break;
> + case HDMI_SRC_DSD:
> + data = (0x2 << 3);
> + break;
> + case HDMI_SRC_HBR:
> + data = (0x3 << 3);
In all above cases parenthesis are superfluous.
Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'include/video')
-rw-r--r-- | include/video/sh_mobile_hdmi.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/include/video/sh_mobile_hdmi.h b/include/video/sh_mobile_hdmi.h index 929c2d3147bc..1e1aa54ab2e4 100644 --- a/include/video/sh_mobile_hdmi.h +++ b/include/video/sh_mobile_hdmi.h | |||
@@ -23,11 +23,11 @@ struct device; | |||
23 | */ | 23 | */ |
24 | 24 | ||
25 | /* Audio source select */ | 25 | /* Audio source select */ |
26 | #define HDMI_SRC_MASK (0xF << 0) | 26 | #define HDMI_SND_SRC_MASK (0xF << 0) |
27 | #define HDMI_SRC_I2S (0 << 0) /* default */ | 27 | #define HDMI_SND_SRC_I2S (0 << 0) /* default */ |
28 | #define HDMI_SRC_SPDIF (1 << 0) | 28 | #define HDMI_SND_SRC_SPDIF (1 << 0) |
29 | #define HDMI_SRC_DSD (2 << 0) | 29 | #define HDMI_SND_SRC_DSD (2 << 0) |
30 | #define HDMI_SRC_HBR (3 << 0) | 30 | #define HDMI_SND_SRC_HBR (3 << 0) |
31 | 31 | ||
32 | struct sh_mobile_hdmi_info { | 32 | struct sh_mobile_hdmi_info { |
33 | struct sh_mobile_lcdc_chan_cfg *lcd_chan; | 33 | struct sh_mobile_lcdc_chan_cfg *lcd_chan; |