diff options
author | Li Zefan <lizf@cn.fujitsu.com> | 2009-12-07 22:14:52 -0500 |
---|---|---|
committer | Frederic Weisbecker <fweisbec@gmail.com> | 2009-12-13 12:37:25 -0500 |
commit | 3b8e4273814a7f9e9a74ece517d9206fea919aaa (patch) | |
tree | aa7960d90fe8cd4b04537bf9ea84ac73cb3b69ad /include/trace | |
parent | 614a71a26ba3d97e9fa85649db69a682b78e407d (diff) |
tracing: Move a printk out of ftrace_raw_reg_event_foo()
Move the printk from each ftrace_raw_reg_event_foo() to
its caller ftrace_event_enable_disable(). This avoids each
regfunc trace event callbacks to handle a same error report
that can be carried from the caller.
See how much space this saves:
text data bss dec hex filename
5345151 1961864 7103260 14410275 dbe223 vmlinux.o.old
5331487 1961864 7103260 14396611 dbacc3 vmlinux.o
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Jason Baron <jbaron@redhat.com>
LKML-Reference: <4B1DC4AC.802@cn.fujitsu.com>
[start cmdline record before calling regfunc to avoid lost
window of pid to comm resolution]
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Diffstat (limited to 'include/trace')
-rw-r--r-- | include/trace/ftrace.h | 16 |
1 files changed, 2 insertions, 14 deletions
diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h index 2af2f7a2c1bd..0c21af85211c 100644 --- a/include/trace/ftrace.h +++ b/include/trace/ftrace.h | |||
@@ -555,13 +555,7 @@ static void ftrace_profile_disable_##name(struct ftrace_event_call *unused)\ | |||
555 | * | 555 | * |
556 | * static int ftrace_reg_event_<call>(struct ftrace_event_call *unused) | 556 | * static int ftrace_reg_event_<call>(struct ftrace_event_call *unused) |
557 | * { | 557 | * { |
558 | * int ret; | 558 | * return register_trace_<call>(ftrace_event_<call>); |
559 | * | ||
560 | * ret = register_trace_<call>(ftrace_event_<call>); | ||
561 | * if (!ret) | ||
562 | * pr_info("event trace: Could not activate trace point " | ||
563 | * "probe to <call>"); | ||
564 | * return ret; | ||
565 | * } | 559 | * } |
566 | * | 560 | * |
567 | * static void ftrace_unreg_event_<call>(struct ftrace_event_call *unused) | 561 | * static void ftrace_unreg_event_<call>(struct ftrace_event_call *unused) |
@@ -710,13 +704,7 @@ static void ftrace_raw_event_##call(proto) \ | |||
710 | \ | 704 | \ |
711 | static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ | 705 | static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ |
712 | { \ | 706 | { \ |
713 | int ret; \ | 707 | return register_trace_##call(ftrace_raw_event_##call); \ |
714 | \ | ||
715 | ret = register_trace_##call(ftrace_raw_event_##call); \ | ||
716 | if (ret) \ | ||
717 | pr_info("event trace: Could not activate trace point " \ | ||
718 | "probe to %s\n", #call); \ | ||
719 | return ret; \ | ||
720 | } \ | 708 | } \ |
721 | \ | 709 | \ |
722 | static void ftrace_raw_unreg_event_##call(struct ftrace_event_call *unused)\ | 710 | static void ftrace_raw_unreg_event_##call(struct ftrace_event_call *unused)\ |