Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback: (27 commits)
  mm: properly reflect task dirty limits in dirty_exceeded logic
  writeback: don't busy retry writeback on new/freeing inodes
  writeback: scale IO chunk size up to half device bandwidth
  writeback: trace global_dirty_state
  writeback: introduce max-pause and pass-good dirty limits
  writeback: introduce smoothed global dirty limit
  writeback: consolidate variable names in balance_dirty_pages()
  writeback: show bdi write bandwidth in debugfs
  writeback: bdi write bandwidth estimation
  writeback: account per-bdi accumulated written pages
  writeback: make writeback_control.nr_to_write straight
  writeback: skip tmpfs early in balance_dirty_pages_ratelimited_nr()
  writeback: trace event writeback_queue_io
  writeback: trace event writeback_single_inode
  writeback: remove .nonblocking and .encountered_congestion
  writeback: remove writeback_control.more_io
  writeback: skip balance_dirty_pages() for in-memory fs
  writeback: add bdi_dirty_limit() kernel-doc
  writeback: avoid extra sync work at enqueue time
  writeback: elevate queue_io() into wb_writeback()
  ...

Fix up trivial conflicts in fs/fs-writeback.c and mm/filemap.c

3 files changed, 173 insertions, 22 deletions

diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
index 4114129f0794..b31702ac15be 100644
--- a/include/trace/events/btrfs.h
+++ b/include/trace/events/btrfs.h
@@ -284,7 +284,6 @@ DECLARE_EVENT_CLASS(btrfs__writepage,
                 __field(        long,   pages_skipped           )
                 __field(        loff_t, range_start             )
                 __field(        loff_t, range_end               )
-                __field(        char,   nonblocking             )
                 __field(        char,   for_kupdate             )
                 __field(        char,   for_reclaim             )
                 __field(        char,   range_cyclic            )
@@ -299,7 +298,6 @@ DECLARE_EVENT_CLASS(btrfs__writepage,
                 __entry->pages_skipped  = wbc->pages_skipped;
                 __entry->range_start    = wbc->range_start;
                 __entry->range_end      = wbc->range_end;
-                __entry->nonblocking    = wbc->nonblocking;
                 __entry->for_kupdate    = wbc->for_kupdate;
                 __entry->for_reclaim    = wbc->for_reclaim;
                 __entry->range_cyclic   = wbc->range_cyclic;
@@ -310,13 +308,13 @@ DECLARE_EVENT_CLASS(btrfs__writepage,
 
         TP_printk("root = %llu(%s), ino = %lu, page_index = %lu, "
                   "nr_to_write = %ld, pages_skipped = %ld, range_start = %llu, "
-                  "range_end = %llu, nonblocking = %d, for_kupdate = %d, "
+                  "range_end = %llu, for_kupdate = %d, "
                   "for_reclaim = %d, range_cyclic = %d, writeback_index = %lu",
                   show_root_type(__entry->root_objectid),
                   (unsigned long)__entry->ino, __entry->index,
                   __entry->nr_to_write, __entry->pages_skipped,
                   __entry->range_start, __entry->range_end,
-                  __entry->nonblocking, __entry->for_kupdate,
+                  __entry->for_kupdate,
                   __entry->for_reclaim, __entry->range_cyclic,
                   (unsigned long)__entry->writeback_index)
 );
diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h
index 5ce2b2f5f524..6363193a3418 100644
--- a/include/trace/events/ext4.h
+++ b/include/trace/events/ext4.h
@@ -380,7 +380,6 @@ TRACE_EVENT(ext4_da_writepages_result,
                 __field(        int,    pages_written           )
                 __field(        long,   pages_skipped           )
                 __field(        int,    sync_mode               )
-                __field(        char,   more_io                 )       
                 __field(       pgoff_t, writeback_index         )
         ),
 
@@ -391,16 +390,15 @@ TRACE_EVENT(ext4_da_writepages_result,
                 __entry->pages_written  = pages_written;
                 __entry->pages_skipped  = wbc->pages_skipped;
                 __entry->sync_mode      = wbc->sync_mode;
-                __entry->more_io        = wbc->more_io;
                 __entry->writeback_index = inode->i_mapping->writeback_index;
         ),
 
         TP_printk("dev %d,%d ino %lu ret %d pages_written %d pages_skipped %ld "
-                  " more_io %d sync_mode %d writeback_index %lu",
+                  "sync_mode %d writeback_index %lu",
                   MAJOR(__entry->dev), MINOR(__entry->dev),
                   (unsigned long) __entry->ino, __entry->ret,
                   __entry->pages_written, __entry->pages_skipped,
-                  __entry->more_io, __entry->sync_mode,
+                  __entry->sync_mode,
                   (unsigned long) __entry->writeback_index)
 );
 
diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
index 4e249b927eaa..6bca4cc0063c 100644
--- a/include/trace/events/writeback.h
+++ b/include/trace/events/writeback.h
@@ -8,6 +8,19 @@
 #include <linux/device.h>
 #include <linux/writeback.h>
 
+#define show_inode_state(state)                                 \
+        __print_flags(state, "|",                               \
+                {I_DIRTY_SYNC,          "I_DIRTY_SYNC"},        \
+                {I_DIRTY_DATASYNC,      "I_DIRTY_DATASYNC"},    \
+                {I_DIRTY_PAGES,         "I_DIRTY_PAGES"},       \
+                {I_NEW,                 "I_NEW"},               \
+                {I_WILL_FREE,           "I_WILL_FREE"},         \
+                {I_FREEING,             "I_FREEING"},           \
+                {I_CLEAR,               "I_CLEAR"},             \
+                {I_SYNC,                "I_SYNC"},              \
+                {I_REFERENCED,          "I_REFERENCED"}         \
+        )
+
 struct wb_writeback_work;
 
 DECLARE_EVENT_CLASS(writeback_work_class,
@@ -49,6 +62,9 @@ DEFINE_EVENT(writeback_work_class, name, \
 DEFINE_WRITEBACK_WORK_EVENT(writeback_nothread);
 DEFINE_WRITEBACK_WORK_EVENT(writeback_queue);
 DEFINE_WRITEBACK_WORK_EVENT(writeback_exec);
+DEFINE_WRITEBACK_WORK_EVENT(writeback_start);
+DEFINE_WRITEBACK_WORK_EVENT(writeback_written);
+DEFINE_WRITEBACK_WORK_EVENT(writeback_wait);
 
 TRACE_EVENT(writeback_pages_written,
         TP_PROTO(long pages_written),
@@ -88,6 +104,30 @@ DEFINE_WRITEBACK_EVENT(writeback_bdi_register);
 DEFINE_WRITEBACK_EVENT(writeback_bdi_unregister);
 DEFINE_WRITEBACK_EVENT(writeback_thread_start);
 DEFINE_WRITEBACK_EVENT(writeback_thread_stop);
+DEFINE_WRITEBACK_EVENT(balance_dirty_start);
+DEFINE_WRITEBACK_EVENT(balance_dirty_wait);
+
+TRACE_EVENT(balance_dirty_written,
+
+        TP_PROTO(struct backing_dev_info *bdi, int written),
+
+        TP_ARGS(bdi, written),
+
+        TP_STRUCT__entry(
+                __array(char,   name, 32)
+                __field(int,    written)
+        ),
+
+        TP_fast_assign(
+                strncpy(__entry->name, dev_name(bdi->dev), 32);
+                __entry->written = written;
+        ),
+
+        TP_printk("bdi %s written %d",
+                  __entry->name,
+                  __entry->written
+        )
+);
 
 DECLARE_EVENT_CLASS(wbc_class,
         TP_PROTO(struct writeback_control *wbc, struct backing_dev_info *bdi),
@@ -101,8 +141,6 @@ DECLARE_EVENT_CLASS(wbc_class,
                 __field(int, for_background)
                 __field(int, for_reclaim)
                 __field(int, range_cyclic)
-                __field(int, more_io)
-                __field(unsigned long, older_than_this)
                 __field(long, range_start)
                 __field(long, range_end)
         ),
@@ -116,15 +154,12 @@ DECLARE_EVENT_CLASS(wbc_class,
                 __entry->for_background = wbc->for_background;
                 __entry->for_reclaim    = wbc->for_reclaim;
                 __entry->range_cyclic   = wbc->range_cyclic;
-                __entry->more_io        = wbc->more_io;
-                __entry->older_than_this = wbc->older_than_this ?
-                                                *wbc->older_than_this : 0;
                 __entry->range_start    = (long)wbc->range_start;
                 __entry->range_end      = (long)wbc->range_end;
         ),
 
         TP_printk("bdi %s: towrt=%ld skip=%ld mode=%d kupd=%d "
-                "bgrd=%d reclm=%d cyclic=%d more=%d older=0x%lx "
+                "bgrd=%d reclm=%d cyclic=%d "
                 "start=0x%lx end=0x%lx",
                 __entry->name,
                 __entry->nr_to_write,
@@ -134,8 +169,6 @@ DECLARE_EVENT_CLASS(wbc_class,
                 __entry->for_background,
                 __entry->for_reclaim,
                 __entry->range_cyclic,
-                __entry->more_io,
-                __entry->older_than_this,
                 __entry->range_start,
                 __entry->range_end)
 )
@@ -144,14 +177,79 @@ DECLARE_EVENT_CLASS(wbc_class,
 DEFINE_EVENT(wbc_class, name, \
         TP_PROTO(struct writeback_control *wbc, struct backing_dev_info *bdi), \
         TP_ARGS(wbc, bdi))
-DEFINE_WBC_EVENT(wbc_writeback_start);
-DEFINE_WBC_EVENT(wbc_writeback_written);
-DEFINE_WBC_EVENT(wbc_writeback_wait);
-DEFINE_WBC_EVENT(wbc_balance_dirty_start);
-DEFINE_WBC_EVENT(wbc_balance_dirty_written);
-DEFINE_WBC_EVENT(wbc_balance_dirty_wait);
 DEFINE_WBC_EVENT(wbc_writepage);
 
+TRACE_EVENT(writeback_queue_io,
+        TP_PROTO(struct bdi_writeback *wb,
+                 unsigned long *older_than_this,
+                 int moved),
+        TP_ARGS(wb, older_than_this, moved),
+        TP_STRUCT__entry(
+                __array(char,           name, 32)
+                __field(unsigned long,  older)
+                __field(long,           age)
+                __field(int,            moved)
+        ),
+        TP_fast_assign(
+                strncpy(__entry->name, dev_name(wb->bdi->dev), 32);
+                __entry->older  = older_than_this ?  *older_than_this : 0;
+                __entry->age    = older_than_this ?
+                                  (jiffies - *older_than_this) * 1000 / HZ : -1;
+                __entry->moved  = moved;
+        ),
+        TP_printk("bdi %s: older=%lu age=%ld enqueue=%d",
+                __entry->name,
+                __entry->older, /* older_than_this in jiffies */
+                __entry->age,   /* older_than_this in relative milliseconds */
+                __entry->moved)
+);
+
+TRACE_EVENT(global_dirty_state,
+
+        TP_PROTO(unsigned long background_thresh,
+                 unsigned long dirty_thresh
+        ),
+
+        TP_ARGS(background_thresh,
+                dirty_thresh
+        ),
+
+        TP_STRUCT__entry(
+                __field(unsigned long,  nr_dirty)
+                __field(unsigned long,  nr_writeback)
+                __field(unsigned long,  nr_unstable)
+                __field(unsigned long,  background_thresh)
+                __field(unsigned long,  dirty_thresh)
+                __field(unsigned long,  dirty_limit)
+                __field(unsigned long,  nr_dirtied)
+                __field(unsigned long,  nr_written)
+        ),
+
+        TP_fast_assign(
+                __entry->nr_dirty       = global_page_state(NR_FILE_DIRTY);
+                __entry->nr_writeback   = global_page_state(NR_WRITEBACK);
+                __entry->nr_unstable    = global_page_state(NR_UNSTABLE_NFS);
+                __entry->nr_dirtied     = global_page_state(NR_DIRTIED);
+                __entry->nr_written     = global_page_state(NR_WRITTEN);
+                __entry->background_thresh = background_thresh;
+                __entry->dirty_thresh   = dirty_thresh;
+                __entry->dirty_limit = global_dirty_limit;
+        ),
+
+        TP_printk("dirty=%lu writeback=%lu unstable=%lu "
+                  "bg_thresh=%lu thresh=%lu limit=%lu "
+                  "dirtied=%lu written=%lu",
+                  __entry->nr_dirty,
+                  __entry->nr_writeback,
+                  __entry->nr_unstable,
+                  __entry->background_thresh,
+                  __entry->dirty_thresh,
+                  __entry->dirty_limit,
+                  __entry->nr_dirtied,
+                  __entry->nr_written
+        )
+);
+
 DECLARE_EVENT_CLASS(writeback_congest_waited_template,
 
         TP_PROTO(unsigned int usec_timeout, unsigned int usec_delayed),
@@ -187,6 +285,63 @@ DEFINE_EVENT(writeback_congest_waited_template, writeback_wait_iff_congested,
         TP_ARGS(usec_timeout, usec_delayed)
 );
 
+DECLARE_EVENT_CLASS(writeback_single_inode_template,
+
+        TP_PROTO(struct inode *inode,
+                 struct writeback_control *wbc,
+                 unsigned long nr_to_write
+        ),
+
+        TP_ARGS(inode, wbc, nr_to_write),
+
+        TP_STRUCT__entry(
+                __array(char, name, 32)
+                __field(unsigned long, ino)
+                __field(unsigned long, state)
+                __field(unsigned long, age)
+                __field(unsigned long, writeback_index)
+                __field(long, nr_to_write)
+                __field(unsigned long, wrote)
+        ),
+
+        TP_fast_assign(
+                strncpy(__entry->name,
+                        dev_name(inode->i_mapping->backing_dev_info->dev), 32);
+                __entry->ino            = inode->i_ino;
+                __entry->state          = inode->i_state;
+                __entry->age            = (jiffies - inode->dirtied_when) *
+                                                                1000 / HZ;
+                __entry->writeback_index = inode->i_mapping->writeback_index;
+                __entry->nr_to_write    = nr_to_write;
+                __entry->wrote          = nr_to_write - wbc->nr_to_write;
+        ),
+
+        TP_printk("bdi %s: ino=%lu state=%s age=%lu "
+                  "index=%lu to_write=%ld wrote=%lu",
+                  __entry->name,
+                  __entry->ino,
+                  show_inode_state(__entry->state),
+                  __entry->age,
+                  __entry->writeback_index,
+                  __entry->nr_to_write,
+                  __entry->wrote
+        )
+);
+
+DEFINE_EVENT(writeback_single_inode_template, writeback_single_inode_requeue,
+        TP_PROTO(struct inode *inode,
+                 struct writeback_control *wbc,
+                 unsigned long nr_to_write),
+        TP_ARGS(inode, wbc, nr_to_write)
+);
+
+DEFINE_EVENT(writeback_single_inode_template, writeback_single_inode,
+        TP_PROTO(struct inode *inode,
+                 struct writeback_control *wbc,
+                 unsigned long nr_to_write),
+        TP_ARGS(inode, wbc, nr_to_write)
+);
+
 #endif /* _TRACE_WRITEBACK_H */
 
 /* This part must be outside protection */