diff options
author | Christoph Hellwig <hch@infradead.org> | 2012-05-20 14:34:44 -0400 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-07-16 20:29:11 -0400 |
commit | 5f41a31d0a49a014adb1588edd0cc7f7e30cc55b (patch) | |
tree | 6ee74b84c59a0473aba1257d2e762fa6935c4066 /include/target | |
parent | a3785c8740c5b56b49ec336b59be996393d83332 (diff) |
target: remove the execute list
Since "target: Drop se_device TCQ queue_depth usage from I/O path" we always
submit all commands (or back then, tasks) from __transport_execute_tasks.
That means the the execute list has lots its purpose, as we can simply
submit the commands that are restarted in transport_complete_task_attr
directly while we walk the list. In fact doing so also solves a race
in the way it currently walks to delayed_cmd_list as well.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'include/target')
-rw-r--r-- | include/target/target_core_base.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index abda19d6cbd2..6e99dc5a5f6b 100644 --- a/include/target/target_core_base.h +++ b/include/target/target_core_base.h | |||
@@ -572,7 +572,6 @@ struct se_cmd { | |||
572 | struct scatterlist *t_bidi_data_sg; | 572 | struct scatterlist *t_bidi_data_sg; |
573 | unsigned int t_bidi_data_nents; | 573 | unsigned int t_bidi_data_nents; |
574 | 574 | ||
575 | struct list_head execute_list; | ||
576 | struct list_head state_list; | 575 | struct list_head state_list; |
577 | bool state_active; | 576 | bool state_active; |
578 | 577 | ||
@@ -777,7 +776,6 @@ struct se_device { | |||
777 | /* Active commands on this virtual SE device */ | 776 | /* Active commands on this virtual SE device */ |
778 | atomic_t simple_cmds; | 777 | atomic_t simple_cmds; |
779 | atomic_t dev_ordered_id; | 778 | atomic_t dev_ordered_id; |
780 | atomic_t execute_tasks; | ||
781 | atomic_t dev_ordered_sync; | 779 | atomic_t dev_ordered_sync; |
782 | atomic_t dev_qf_count; | 780 | atomic_t dev_qf_count; |
783 | struct se_obj dev_obj; | 781 | struct se_obj dev_obj; |
@@ -803,7 +801,6 @@ struct se_device { | |||
803 | struct task_struct *process_thread; | 801 | struct task_struct *process_thread; |
804 | struct work_struct qf_work_queue; | 802 | struct work_struct qf_work_queue; |
805 | struct list_head delayed_cmd_list; | 803 | struct list_head delayed_cmd_list; |
806 | struct list_head execute_list; | ||
807 | struct list_head state_list; | 804 | struct list_head state_list; |
808 | struct list_head qf_cmd_list; | 805 | struct list_head qf_cmd_list; |
809 | /* Pointer to associated SE HBA */ | 806 | /* Pointer to associated SE HBA */ |