diff options
author | Christoph Hellwig <hch@infradead.org> | 2011-11-23 06:54:36 -0500 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2011-12-14 06:27:02 -0500 |
commit | 1880807adb21d741f08b747956c90bf4a6f95fbf (patch) | |
tree | fb3815bf85679116bb455ded1a678049950a3d9f /include/target | |
parent | 41e16e981679124c78c30f046d4f0b71d86ff1b2 (diff) |
target: make the se_task task_state_active a normal bool
There is no need to make task_state_active an atomic_t given that it is
always set under the execute_task_lock so we can make it a simple bool.
Also rename it to t_state_active to be closer to the list it guards,
and make sure all checks before the list addion/removal actually happen
under execute_task_lock.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'include/target')
-rw-r--r-- | include/target/target_core_base.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index e2473e6770b3..311f5fc607e6 100644 --- a/include/target/target_core_base.h +++ b/include/target/target_core_base.h | |||
@@ -491,10 +491,10 @@ struct se_task { | |||
491 | u16 task_flags; | 491 | u16 task_flags; |
492 | u8 task_scsi_status; | 492 | u8 task_scsi_status; |
493 | enum dma_data_direction task_data_direction; | 493 | enum dma_data_direction task_data_direction; |
494 | atomic_t task_state_active; | ||
495 | struct list_head t_list; | 494 | struct list_head t_list; |
496 | struct list_head t_execute_list; | 495 | struct list_head t_execute_list; |
497 | struct list_head t_state_list; | 496 | struct list_head t_state_list; |
497 | bool t_state_active; | ||
498 | struct completion task_stop_comp; | 498 | struct completion task_stop_comp; |
499 | } ____cacheline_aligned; | 499 | } ____cacheline_aligned; |
500 | 500 | ||