diff options
author | Takashi Iwai <tiwai@suse.de> | 2008-08-08 11:06:01 -0400 |
---|---|---|
committer | Jaroslav Kysela <perex@perex.cz> | 2008-08-13 05:46:32 -0400 |
commit | 5ef03460a6ffc1d3ee6b6f2abc6765d3e224cf89 (patch) | |
tree | 1947acad9b61fa80567fa1dd20c5b8c65ff8a46d /include/sound | |
parent | 3caf8c080ef0bd0ccdc20bb57b150b6e40a86fd3 (diff) |
ALSA: Introduce snd_BUG_ON() macro
Introduced snd_BUG_ON() macro as a replacement of snd_assert() macro.
snd_assert() is pretty ugly as it has the control flow in its argument.
OTOH, snd_BUG_ON() behaves like a normal conditional, thus it's much
easier to read the flow.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Diffstat (limited to 'include/sound')
-rw-r--r-- | include/sound/core.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/include/sound/core.h b/include/sound/core.h index 1a4ff0bdcf6a..938c36a0e874 100644 --- a/include/sound/core.h +++ b/include/sound/core.h | |||
@@ -28,6 +28,7 @@ | |||
28 | #include <linux/rwsem.h> /* struct rw_semaphore */ | 28 | #include <linux/rwsem.h> /* struct rw_semaphore */ |
29 | #include <linux/pm.h> /* pm_message_t */ | 29 | #include <linux/pm.h> /* pm_message_t */ |
30 | #include <linux/device.h> | 30 | #include <linux/device.h> |
31 | #include <linux/stringify.h> | ||
31 | 32 | ||
32 | /* number of supported soundcards */ | 33 | /* number of supported soundcards */ |
33 | #ifdef CONFIG_SND_DYNAMIC_MINORS | 34 | #ifdef CONFIG_SND_DYNAMIC_MINORS |
@@ -405,11 +406,14 @@ void snd_verbose_printd(const char *file, int line, const char *format, ...) | |||
405 | dump_stack(); \ | 406 | dump_stack(); \ |
406 | } while (0) | 407 | } while (0) |
407 | 408 | ||
409 | #define snd_BUG_ON(cond) WARN((cond), "BUG? (%s)\n", __stringify(cond)) | ||
410 | |||
408 | #else /* !CONFIG_SND_DEBUG */ | 411 | #else /* !CONFIG_SND_DEBUG */ |
409 | 412 | ||
410 | #define snd_printd(fmt, args...) /* nothing */ | 413 | #define snd_printd(fmt, args...) /* nothing */ |
411 | #define snd_assert(expr, args...) (void)(expr) | 414 | #define snd_assert(expr, args...) (void)(expr) |
412 | #define snd_BUG() /* nothing */ | 415 | #define snd_BUG() /* nothing */ |
416 | #define snd_BUG_ON(cond) ({/*(void)(cond);*/ 0;}) /* always false */ | ||
413 | 417 | ||
414 | #endif /* CONFIG_SND_DEBUG */ | 418 | #endif /* CONFIG_SND_DEBUG */ |
415 | 419 | ||