diff options
author | Christoph Hellwig <hch@lst.de> | 2014-11-13 08:25:11 -0500 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2014-11-24 08:45:12 -0500 |
commit | c40ecc12cfdb630332198a04e2832ae8218a61f1 (patch) | |
tree | 881456a7d46ca017dba4cc003e2fe1be427614fc /include/scsi | |
parent | 89dac7bb3b0494685241369951f95494e86ee61f (diff) |
scsi: avoid ->change_queue_depth indirection for queue full tracking
All drivers use the implementation for ramping the queue up and down, so
instead of overloading the change_queue_depth method call the
implementation diretly if the driver opts into it by setting the
track_queue_depth flag in the host template.
Note that a few drivers validated the new queue depth in their
change_queue_depth method, but as we never go over the queue depth
set during slave_configure or the sysfs file this isn't nessecary
and can safely be removed.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Venkatesh Srinivas <venkateshs@google.com>
Diffstat (limited to 'include/scsi')
-rw-r--r-- | include/scsi/scsi_host.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h index 61a81bf77e28..a0b13a5cd25e 100644 --- a/include/scsi/scsi_host.h +++ b/include/scsi/scsi_host.h | |||
@@ -48,8 +48,6 @@ struct blk_queue_tags; | |||
48 | 48 | ||
49 | enum { | 49 | enum { |
50 | SCSI_QDEPTH_DEFAULT, /* default requested change, e.g. from sysfs */ | 50 | SCSI_QDEPTH_DEFAULT, /* default requested change, e.g. from sysfs */ |
51 | SCSI_QDEPTH_QFULL, /* scsi-ml requested due to queue full */ | ||
52 | SCSI_QDEPTH_RAMP_UP, /* scsi-ml requested due to threshold event */ | ||
53 | }; | 51 | }; |
54 | 52 | ||
55 | struct scsi_host_template { | 53 | struct scsi_host_template { |
@@ -427,6 +425,11 @@ struct scsi_host_template { | |||
427 | unsigned use_blk_tags:1; | 425 | unsigned use_blk_tags:1; |
428 | 426 | ||
429 | /* | 427 | /* |
428 | * Track QUEUE_FULL events and reduce queue depth on demand. | ||
429 | */ | ||
430 | unsigned track_queue_depth:1; | ||
431 | |||
432 | /* | ||
430 | * This specifies the mode that a LLD supports. | 433 | * This specifies the mode that a LLD supports. |
431 | */ | 434 | */ |
432 | unsigned supported_mode:2; | 435 | unsigned supported_mode:2; |