diff options
author | Matthew Wilcox <matthew@wil.cx> | 2007-09-18 21:54:43 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.localdomain> | 2007-10-12 14:51:52 -0400 |
commit | 12a441622b753684cc73d1c6f225e9ac53e0bf77 (patch) | |
tree | 71a2314ae948c0e2697d68a902d6bfbec85e1fc0 /include/scsi | |
parent | 13ba9bcbfd6741e4c01ac5a505888b7b3a6d99da (diff) |
[SCSI] Remove ->pid field from scsi_cmnd
The pid field is a duplicate of the serial_number field and has been
scheduled for removal for a long time. A few drivers were still using
it, so just change them to use serial_number instead.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'include/scsi')
-rw-r--r-- | include/scsi/scsi_cmnd.h | 11 | ||||
-rw-r--r-- | include/scsi/scsi_host.h | 2 |
2 files changed, 5 insertions, 8 deletions
diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h index 53e170586c26..4fddef727467 100644 --- a/include/scsi/scsi_cmnd.h +++ b/include/scsi/scsi_cmnd.h | |||
@@ -39,14 +39,12 @@ struct scsi_cmnd { | |||
39 | * A SCSI Command is assigned a nonzero serial_number before passed | 39 | * A SCSI Command is assigned a nonzero serial_number before passed |
40 | * to the driver's queue command function. The serial_number is | 40 | * to the driver's queue command function. The serial_number is |
41 | * cleared when scsi_done is entered indicating that the command | 41 | * cleared when scsi_done is entered indicating that the command |
42 | * has been completed. It currently doesn't have much use other | 42 | * has been completed. It is a bug for LLDDs to use this number |
43 | * than printk's. Some lldd's use this number for other purposes. | 43 | * for purposes other than printk (and even that is only useful |
44 | * It's almost certain that such usages are either incorrect or | 44 | * for debugging). |
45 | * meaningless. Please kill all usages other than printk's. Also, | ||
46 | * as this number is always identical to ->pid, please convert | ||
47 | * printk's to use ->pid, so that we can kill this field. | ||
48 | */ | 45 | */ |
49 | unsigned long serial_number; | 46 | unsigned long serial_number; |
47 | |||
50 | /* | 48 | /* |
51 | * This is set to jiffies as it was when the command was first | 49 | * This is set to jiffies as it was when the command was first |
52 | * allocated. It is used to time how long the command has | 50 | * allocated. It is used to time how long the command has |
@@ -116,7 +114,6 @@ struct scsi_cmnd { | |||
116 | int result; /* Status code from lower level driver */ | 114 | int result; /* Status code from lower level driver */ |
117 | 115 | ||
118 | unsigned char tag; /* SCSI-II queued command tag */ | 116 | unsigned char tag; /* SCSI-II queued command tag */ |
119 | unsigned long pid; /* Process ID, starts at 0. Unique per host. */ | ||
120 | }; | 117 | }; |
121 | 118 | ||
122 | extern struct scsi_cmnd *scsi_get_command(struct scsi_device *, gfp_t); | 119 | extern struct scsi_cmnd *scsi_get_command(struct scsi_device *, gfp_t); |
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h index 5b79697a3a80..7d210cd6c38d 100644 --- a/include/scsi/scsi_host.h +++ b/include/scsi/scsi_host.h | |||
@@ -580,7 +580,7 @@ struct Scsi_Host { | |||
580 | * Used to assign serial numbers to the cmds. | 580 | * Used to assign serial numbers to the cmds. |
581 | * Protected by the host lock. | 581 | * Protected by the host lock. |
582 | */ | 582 | */ |
583 | unsigned long cmd_serial_number, cmd_pid; | 583 | unsigned long cmd_serial_number; |
584 | 584 | ||
585 | unsigned active_mode:2; | 585 | unsigned active_mode:2; |
586 | unsigned unchecked_isa_dma:1; | 586 | unsigned unchecked_isa_dma:1; |