aboutsummaryrefslogtreecommitdiffstats
path: root/include/scsi
diff options
context:
space:
mode:
authorEddie Wai <eddie.wai@broadcom.com>2010-11-23 18:29:21 -0500
committerJames Bottomley <James.Bottomley@suse.de>2010-12-21 13:24:10 -0500
commit8eea2f55a65b9471276e78e5c86ddd19c4c0365c (patch)
tree5b40a3401d20d6d40ce22e86307e3252a3e7b67d /include/scsi
parent5ee32576269f33b66c6dbc98144aead1e74a1e91 (diff)
[SCSI] bnx2i: Added fix for NOP-Out response panic from unsolicited NOP-In
The patch fixes the following situations where NOP-Out pkt is called for: - local unsolicited NOP-Out requests (requesting no NOP-In response) - local NOP-Out responses to unsolicited NOP-In requests kernel panic is observed due to double session spin_lock requests; one in the bnx2i_process_nopin_local_cmpl routine in bnx2i_hwi.c and the other in the iscsi_put_task routine in libiscsi.c The proposed fix is to export the currently static __iscsi_put_task() routine and have bnx2i call it directly instead of the iscsi_put_task() routine which holds the session spin lock. Signed-off-by: Eddie Wai <eddie.wai@broadcom.com> Reviewed-by: Michael Chan <mchan@broadcom.com> Reviewed-by: Anil Veerabhadrappa <anilgv@broadcom.com> Acked-by: Benjamin Li <benli@broadcom.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'include/scsi')
-rw-r--r--include/scsi/libiscsi.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/include/scsi/libiscsi.h b/include/scsi/libiscsi.h
index b81d969ddc67..68e951d79f0b 100644
--- a/include/scsi/libiscsi.h
+++ b/include/scsi/libiscsi.h
@@ -419,6 +419,7 @@ extern struct iscsi_task *iscsi_itt_to_ctask(struct iscsi_conn *, itt_t);
419extern struct iscsi_task *iscsi_itt_to_task(struct iscsi_conn *, itt_t); 419extern struct iscsi_task *iscsi_itt_to_task(struct iscsi_conn *, itt_t);
420extern void iscsi_requeue_task(struct iscsi_task *task); 420extern void iscsi_requeue_task(struct iscsi_task *task);
421extern void iscsi_put_task(struct iscsi_task *task); 421extern void iscsi_put_task(struct iscsi_task *task);
422extern void __iscsi_put_task(struct iscsi_task *task);
422extern void __iscsi_get_task(struct iscsi_task *task); 423extern void __iscsi_get_task(struct iscsi_task *task);
423extern void iscsi_complete_scsi_task(struct iscsi_task *task, 424extern void iscsi_complete_scsi_task(struct iscsi_task *task,
424 uint32_t exp_cmdsn, uint32_t max_cmdsn); 425 uint32_t exp_cmdsn, uint32_t max_cmdsn);