diff options
author | Matthew Wilcox <matthew@wil.cx> | 2007-09-25 12:42:04 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.localdomain> | 2007-10-12 14:52:46 -0400 |
commit | 6f5391c283d7fdcf24bf40786ea79061919d1e1d (patch) | |
tree | 32ee9abddf9879445792019e1c03bcd28ce6bd4f /include/scsi/scsi_cmnd.h | |
parent | 687d2bc4877081a44c41b5b312e012cc69edda53 (diff) |
[SCSI] Get rid of scsi_cmnd->done
The ULD ->done callback moves into the scsi_driver. By moving the call
to scsi_io_completion() from scsi_blk_pc_done() to scsi_finish_command(),
we can eliminate the latter entirely. By returning 'good_bytes' from
the ->done callback (rather than invoking scsi_io_completion()), we can
stop exporting scsi_io_completion().
Also move the prototypes from sd.h to sd.c as they're all internal anyway.
Rename sd_rw_intr to sd_done and rw_intr to sr_done.
Inspired-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'include/scsi/scsi_cmnd.h')
-rw-r--r-- | include/scsi/scsi_cmnd.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h index 4fddef727467..65ab5145a09b 100644 --- a/include/scsi/scsi_cmnd.h +++ b/include/scsi/scsi_cmnd.h | |||
@@ -33,7 +33,6 @@ struct scsi_cmnd { | |||
33 | struct list_head list; /* scsi_cmnd participates in queue lists */ | 33 | struct list_head list; /* scsi_cmnd participates in queue lists */ |
34 | struct list_head eh_entry; /* entry for the host eh_cmd_q */ | 34 | struct list_head eh_entry; /* entry for the host eh_cmd_q */ |
35 | int eh_eflags; /* Used by error handlr */ | 35 | int eh_eflags; /* Used by error handlr */ |
36 | void (*done) (struct scsi_cmnd *); /* Mid-level done function */ | ||
37 | 36 | ||
38 | /* | 37 | /* |
39 | * A SCSI Command is assigned a nonzero serial_number before passed | 38 | * A SCSI Command is assigned a nonzero serial_number before passed |
@@ -121,7 +120,6 @@ extern struct scsi_cmnd *__scsi_get_command(struct Scsi_Host *, gfp_t); | |||
121 | extern void scsi_put_command(struct scsi_cmnd *); | 120 | extern void scsi_put_command(struct scsi_cmnd *); |
122 | extern void __scsi_put_command(struct Scsi_Host *, struct scsi_cmnd *, | 121 | extern void __scsi_put_command(struct Scsi_Host *, struct scsi_cmnd *, |
123 | struct device *); | 122 | struct device *); |
124 | extern void scsi_io_completion(struct scsi_cmnd *, unsigned int); | ||
125 | extern void scsi_finish_command(struct scsi_cmnd *cmd); | 123 | extern void scsi_finish_command(struct scsi_cmnd *cmd); |
126 | extern void scsi_req_abort_cmd(struct scsi_cmnd *cmd); | 124 | extern void scsi_req_abort_cmd(struct scsi_cmnd *cmd); |
127 | 125 | ||