diff options
author | David S. Miller <davem@sunset.davemloft.net> | 2006-08-22 02:54:55 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-09-22 17:55:10 -0400 |
commit | e9ce1cd3cf6cf35b21d0ce990f2e738f35907386 (patch) | |
tree | 22a3ee7b78ae7cbf00520c66dcc389d87740069c /include/net | |
parent | 2e4ca75b31b6851dcc036c2cdebf3ecfe279a653 (diff) |
[PKT_SCHED]: Kill pkt_act.h inlining.
This was simply making templates of functions and mostly causing a lot
of code duplication in the classifier action modules.
We solve this more cleanly by having a common "struct tcf_common" that
hash worker functions contained once in act_api.c can work with.
Callers work with real action objects that have the common struct
plus their module specific struct members. You go from a common
object to the higher level one using a "to_foo()" macro which makes
use of container_of() to do the dirty work.
This also kills off act_generic.h which was only used by act_simple.c
and keeping it around was more work than the it's value.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net')
-rw-r--r-- | include/net/act_api.h | 136 | ||||
-rw-r--r-- | include/net/act_generic.h | 142 | ||||
-rw-r--r-- | include/net/pkt_act.h | 273 | ||||
-rw-r--r-- | include/net/tc_act/tc_defact.h | 13 | ||||
-rw-r--r-- | include/net/tc_act/tc_gact.h | 18 | ||||
-rw-r--r-- | include/net/tc_act/tc_ipt.h | 15 | ||||
-rw-r--r-- | include/net/tc_act/tc_mirred.h | 17 | ||||
-rw-r--r-- | include/net/tc_act/tc_pedit.h | 15 |
8 files changed, 129 insertions, 500 deletions
diff --git a/include/net/act_api.h b/include/net/act_api.h index 11e9eaf79f5a..8b06c2f3657f 100644 --- a/include/net/act_api.h +++ b/include/net/act_api.h | |||
@@ -8,70 +8,110 @@ | |||
8 | #include <net/sch_generic.h> | 8 | #include <net/sch_generic.h> |
9 | #include <net/pkt_sched.h> | 9 | #include <net/pkt_sched.h> |
10 | 10 | ||
11 | #define tca_gen(name) \ | 11 | struct tcf_common { |
12 | struct tcf_##name *next; \ | 12 | struct tcf_common *tcfc_next; |
13 | u32 index; \ | 13 | u32 tcfc_index; |
14 | int refcnt; \ | 14 | int tcfc_refcnt; |
15 | int bindcnt; \ | 15 | int tcfc_bindcnt; |
16 | u32 capab; \ | 16 | u32 tcfc_capab; |
17 | int action; \ | 17 | int tcfc_action; |
18 | struct tcf_t tm; \ | 18 | struct tcf_t tcfc_tm; |
19 | struct gnet_stats_basic bstats; \ | 19 | struct gnet_stats_basic tcfc_bstats; |
20 | struct gnet_stats_queue qstats; \ | 20 | struct gnet_stats_queue tcfc_qstats; |
21 | struct gnet_stats_rate_est rate_est; \ | 21 | struct gnet_stats_rate_est tcfc_rate_est; |
22 | spinlock_t *stats_lock; \ | 22 | spinlock_t *tcfc_stats_lock; |
23 | spinlock_t lock | 23 | spinlock_t tcfc_lock; |
24 | 24 | }; | |
25 | struct tcf_police | 25 | #define tcf_next common.tcfc_next |
26 | { | 26 | #define tcf_index common.tcfc_index |
27 | tca_gen(police); | 27 | #define tcf_refcnt common.tcfc_refcnt |
28 | int result; | 28 | #define tcf_bindcnt common.tcfc_bindcnt |
29 | u32 ewma_rate; | 29 | #define tcf_capab common.tcfc_capab |
30 | u32 burst; | 30 | #define tcf_action common.tcfc_action |
31 | u32 mtu; | 31 | #define tcf_tm common.tcfc_tm |
32 | u32 toks; | 32 | #define tcf_bstats common.tcfc_bstats |
33 | u32 ptoks; | 33 | #define tcf_qstats common.tcfc_qstats |
34 | psched_time_t t_c; | 34 | #define tcf_rate_est common.tcfc_rate_est |
35 | struct qdisc_rate_table *R_tab; | 35 | #define tcf_stats_lock common.tcfc_stats_lock |
36 | struct qdisc_rate_table *P_tab; | 36 | #define tcf_lock common.tcfc_lock |
37 | |||
38 | struct tcf_police { | ||
39 | struct tcf_common common; | ||
40 | int tcfp_result; | ||
41 | u32 tcfp_ewma_rate; | ||
42 | u32 tcfp_burst; | ||
43 | u32 tcfp_mtu; | ||
44 | u32 tcfp_toks; | ||
45 | u32 tcfp_ptoks; | ||
46 | psched_time_t tcfp_t_c; | ||
47 | struct qdisc_rate_table *tcfp_R_tab; | ||
48 | struct qdisc_rate_table *tcfp_P_tab; | ||
37 | }; | 49 | }; |
50 | #define to_police(pc) \ | ||
51 | container_of(pc, struct tcf_police, common) | ||
52 | |||
53 | struct tcf_hashinfo { | ||
54 | struct tcf_common **htab; | ||
55 | unsigned int hmask; | ||
56 | rwlock_t *lock; | ||
57 | }; | ||
58 | |||
59 | static inline unsigned int tcf_hash(u32 index, unsigned int hmask) | ||
60 | { | ||
61 | return index & hmask; | ||
62 | } | ||
38 | 63 | ||
39 | #ifdef CONFIG_NET_CLS_ACT | 64 | #ifdef CONFIG_NET_CLS_ACT |
40 | 65 | ||
41 | #define ACT_P_CREATED 1 | 66 | #define ACT_P_CREATED 1 |
42 | #define ACT_P_DELETED 1 | 67 | #define ACT_P_DELETED 1 |
43 | 68 | ||
44 | struct tcf_act_hdr | 69 | struct tcf_act_hdr { |
45 | { | 70 | struct tcf_common common; |
46 | tca_gen(act_hdr); | ||
47 | }; | 71 | }; |
48 | 72 | ||
49 | struct tc_action | 73 | struct tc_action { |
50 | { | 74 | void *priv; |
51 | void *priv; | 75 | struct tc_action_ops *ops; |
52 | struct tc_action_ops *ops; | 76 | __u32 type; /* for backward compat(TCA_OLD_COMPAT) */ |
53 | __u32 type; /* for backward compat(TCA_OLD_COMPAT) */ | 77 | __u32 order; |
54 | __u32 order; | 78 | struct tc_action *next; |
55 | struct tc_action *next; | ||
56 | }; | 79 | }; |
57 | 80 | ||
58 | #define TCA_CAP_NONE 0 | 81 | #define TCA_CAP_NONE 0 |
59 | struct tc_action_ops | 82 | struct tc_action_ops { |
60 | { | ||
61 | struct tc_action_ops *next; | 83 | struct tc_action_ops *next; |
84 | struct tcf_hashinfo *hinfo; | ||
62 | char kind[IFNAMSIZ]; | 85 | char kind[IFNAMSIZ]; |
63 | __u32 type; /* TBD to match kind */ | 86 | __u32 type; /* TBD to match kind */ |
64 | __u32 capab; /* capabilities includes 4 bit version */ | 87 | __u32 capab; /* capabilities includes 4 bit version */ |
65 | struct module *owner; | 88 | struct module *owner; |
66 | int (*act)(struct sk_buff *, struct tc_action *, struct tcf_result *); | 89 | int (*act)(struct sk_buff *, struct tc_action *, struct tcf_result *); |
67 | int (*get_stats)(struct sk_buff *, struct tc_action *); | 90 | int (*get_stats)(struct sk_buff *, struct tc_action *); |
68 | int (*dump)(struct sk_buff *, struct tc_action *,int , int); | 91 | int (*dump)(struct sk_buff *, struct tc_action *, int, int); |
69 | int (*cleanup)(struct tc_action *, int bind); | 92 | int (*cleanup)(struct tc_action *, int bind); |
70 | int (*lookup)(struct tc_action *, u32 ); | 93 | int (*lookup)(struct tc_action *, u32); |
71 | int (*init)(struct rtattr *,struct rtattr *,struct tc_action *, int , int ); | 94 | int (*init)(struct rtattr *, struct rtattr *, struct tc_action *, int , int); |
72 | int (*walk)(struct sk_buff *, struct netlink_callback *, int , struct tc_action *); | 95 | int (*walk)(struct sk_buff *, struct netlink_callback *, int, struct tc_action *); |
73 | }; | 96 | }; |
74 | 97 | ||
98 | extern struct tcf_common *tcf_hash_lookup(u32 index, | ||
99 | struct tcf_hashinfo *hinfo); | ||
100 | extern void tcf_hash_destroy(struct tcf_common *p, struct tcf_hashinfo *hinfo); | ||
101 | extern int tcf_hash_release(struct tcf_common *p, int bind, | ||
102 | struct tcf_hashinfo *hinfo); | ||
103 | extern int tcf_generic_walker(struct sk_buff *skb, struct netlink_callback *cb, | ||
104 | int type, struct tc_action *a); | ||
105 | extern u32 tcf_hash_new_index(u32 *idx_gen, struct tcf_hashinfo *hinfo); | ||
106 | extern int tcf_hash_search(struct tc_action *a, u32 index); | ||
107 | extern struct tcf_common *tcf_hash_check(u32 index, struct tc_action *a, | ||
108 | int bind, struct tcf_hashinfo *hinfo); | ||
109 | extern struct tcf_common *tcf_hash_create(u32 index, struct rtattr *est, | ||
110 | struct tc_action *a, int size, | ||
111 | int bind, u32 *idx_gen, | ||
112 | struct tcf_hashinfo *hinfo); | ||
113 | extern void tcf_hash_insert(struct tcf_common *p, struct tcf_hashinfo *hinfo); | ||
114 | |||
75 | extern int tcf_register_action(struct tc_action_ops *a); | 115 | extern int tcf_register_action(struct tc_action_ops *a); |
76 | extern int tcf_unregister_action(struct tc_action_ops *a); | 116 | extern int tcf_unregister_action(struct tc_action_ops *a); |
77 | extern void tcf_action_destroy(struct tc_action *a, int bind); | 117 | extern void tcf_action_destroy(struct tc_action *a, int bind); |
@@ -96,17 +136,17 @@ tcf_police_release(struct tcf_police *p, int bind) | |||
96 | int ret = 0; | 136 | int ret = 0; |
97 | #ifdef CONFIG_NET_CLS_ACT | 137 | #ifdef CONFIG_NET_CLS_ACT |
98 | if (p) { | 138 | if (p) { |
99 | if (bind) { | 139 | if (bind) |
100 | p->bindcnt--; | 140 | p->tcf_bindcnt--; |
101 | } | 141 | |
102 | p->refcnt--; | 142 | p->tcf_refcnt--; |
103 | if (p->refcnt <= 0 && !p->bindcnt) { | 143 | if (p->tcf_refcnt <= 0 && !p->tcf_bindcnt) { |
104 | tcf_police_destroy(p); | 144 | tcf_police_destroy(p); |
105 | ret = 1; | 145 | ret = 1; |
106 | } | 146 | } |
107 | } | 147 | } |
108 | #else | 148 | #else |
109 | if (p && --p->refcnt == 0) | 149 | if (p && --p->tcf_refcnt == 0) |
110 | tcf_police_destroy(p); | 150 | tcf_police_destroy(p); |
111 | 151 | ||
112 | #endif /* CONFIG_NET_CLS_ACT */ | 152 | #endif /* CONFIG_NET_CLS_ACT */ |
diff --git a/include/net/act_generic.h b/include/net/act_generic.h deleted file mode 100644 index c9daa7e52300..000000000000 --- a/include/net/act_generic.h +++ /dev/null | |||
@@ -1,142 +0,0 @@ | |||
1 | /* | ||
2 | * include/net/act_generic.h | ||
3 | * | ||
4 | */ | ||
5 | #ifndef _NET_ACT_GENERIC_H | ||
6 | #define _NET_ACT_GENERIC_H | ||
7 | static inline int tcf_defact_release(struct tcf_defact *p, int bind) | ||
8 | { | ||
9 | int ret = 0; | ||
10 | if (p) { | ||
11 | if (bind) { | ||
12 | p->bindcnt--; | ||
13 | } | ||
14 | p->refcnt--; | ||
15 | if (p->bindcnt <= 0 && p->refcnt <= 0) { | ||
16 | kfree(p->defdata); | ||
17 | tcf_hash_destroy(p); | ||
18 | ret = 1; | ||
19 | } | ||
20 | } | ||
21 | return ret; | ||
22 | } | ||
23 | |||
24 | static inline int | ||
25 | alloc_defdata(struct tcf_defact *p, u32 datalen, void *defdata) | ||
26 | { | ||
27 | p->defdata = kmalloc(datalen, GFP_KERNEL); | ||
28 | if (p->defdata == NULL) | ||
29 | return -ENOMEM; | ||
30 | p->datalen = datalen; | ||
31 | memcpy(p->defdata, defdata, datalen); | ||
32 | return 0; | ||
33 | } | ||
34 | |||
35 | static inline int | ||
36 | realloc_defdata(struct tcf_defact *p, u32 datalen, void *defdata) | ||
37 | { | ||
38 | /* safer to be just brute force for now */ | ||
39 | kfree(p->defdata); | ||
40 | return alloc_defdata(p, datalen, defdata); | ||
41 | } | ||
42 | |||
43 | static inline int | ||
44 | tcf_defact_init(struct rtattr *rta, struct rtattr *est, | ||
45 | struct tc_action *a, int ovr, int bind) | ||
46 | { | ||
47 | struct rtattr *tb[TCA_DEF_MAX]; | ||
48 | struct tc_defact *parm; | ||
49 | struct tcf_defact *p; | ||
50 | void *defdata; | ||
51 | u32 datalen = 0; | ||
52 | int ret = 0; | ||
53 | |||
54 | if (rta == NULL || rtattr_parse_nested(tb, TCA_DEF_MAX, rta) < 0) | ||
55 | return -EINVAL; | ||
56 | |||
57 | if (tb[TCA_DEF_PARMS - 1] == NULL || | ||
58 | RTA_PAYLOAD(tb[TCA_DEF_PARMS - 1]) < sizeof(*parm)) | ||
59 | return -EINVAL; | ||
60 | |||
61 | parm = RTA_DATA(tb[TCA_DEF_PARMS - 1]); | ||
62 | defdata = RTA_DATA(tb[TCA_DEF_DATA - 1]); | ||
63 | if (defdata == NULL) | ||
64 | return -EINVAL; | ||
65 | |||
66 | datalen = RTA_PAYLOAD(tb[TCA_DEF_DATA - 1]); | ||
67 | if (datalen <= 0) | ||
68 | return -EINVAL; | ||
69 | |||
70 | p = tcf_hash_check(parm->index, a, ovr, bind); | ||
71 | if (p == NULL) { | ||
72 | p = tcf_hash_create(parm->index, est, a, sizeof(*p), ovr, bind); | ||
73 | if (p == NULL) | ||
74 | return -ENOMEM; | ||
75 | |||
76 | ret = alloc_defdata(p, datalen, defdata); | ||
77 | if (ret < 0) { | ||
78 | kfree(p); | ||
79 | return ret; | ||
80 | } | ||
81 | ret = ACT_P_CREATED; | ||
82 | } else { | ||
83 | if (!ovr) { | ||
84 | tcf_defact_release(p, bind); | ||
85 | return -EEXIST; | ||
86 | } | ||
87 | realloc_defdata(p, datalen, defdata); | ||
88 | } | ||
89 | |||
90 | spin_lock_bh(&p->lock); | ||
91 | p->action = parm->action; | ||
92 | spin_unlock_bh(&p->lock); | ||
93 | if (ret == ACT_P_CREATED) | ||
94 | tcf_hash_insert(p); | ||
95 | return ret; | ||
96 | } | ||
97 | |||
98 | static inline int tcf_defact_cleanup(struct tc_action *a, int bind) | ||
99 | { | ||
100 | struct tcf_defact *p = PRIV(a, defact); | ||
101 | |||
102 | if (p != NULL) | ||
103 | return tcf_defact_release(p, bind); | ||
104 | return 0; | ||
105 | } | ||
106 | |||
107 | static inline int | ||
108 | tcf_defact_dump(struct sk_buff *skb, struct tc_action *a, int bind, int ref) | ||
109 | { | ||
110 | unsigned char *b = skb->tail; | ||
111 | struct tc_defact opt; | ||
112 | struct tcf_defact *p = PRIV(a, defact); | ||
113 | struct tcf_t t; | ||
114 | |||
115 | opt.index = p->index; | ||
116 | opt.refcnt = p->refcnt - ref; | ||
117 | opt.bindcnt = p->bindcnt - bind; | ||
118 | opt.action = p->action; | ||
119 | RTA_PUT(skb, TCA_DEF_PARMS, sizeof(opt), &opt); | ||
120 | RTA_PUT(skb, TCA_DEF_DATA, p->datalen, p->defdata); | ||
121 | t.install = jiffies_to_clock_t(jiffies - p->tm.install); | ||
122 | t.lastuse = jiffies_to_clock_t(jiffies - p->tm.lastuse); | ||
123 | t.expires = jiffies_to_clock_t(p->tm.expires); | ||
124 | RTA_PUT(skb, TCA_DEF_TM, sizeof(t), &t); | ||
125 | return skb->len; | ||
126 | |||
127 | rtattr_failure: | ||
128 | skb_trim(skb, b - skb->data); | ||
129 | return -1; | ||
130 | } | ||
131 | |||
132 | #define tca_use_default_ops \ | ||
133 | .dump = tcf_defact_dump, \ | ||
134 | .cleanup = tcf_defact_cleanup, \ | ||
135 | .init = tcf_defact_init, \ | ||
136 | .walk = tcf_generic_walker, \ | ||
137 | |||
138 | #define tca_use_default_defines(name) \ | ||
139 | static u32 idx_gen; \ | ||
140 | static struct tcf_defact *tcf_##name_ht[MY_TAB_SIZE]; \ | ||
141 | static DEFINE_RWLOCK(##name_lock); | ||
142 | #endif /* _NET_ACT_GENERIC_H */ | ||
diff --git a/include/net/pkt_act.h b/include/net/pkt_act.h deleted file mode 100644 index cf5e4d2e4c21..000000000000 --- a/include/net/pkt_act.h +++ /dev/null | |||
@@ -1,273 +0,0 @@ | |||
1 | #ifndef __NET_PKT_ACT_H | ||
2 | #define __NET_PKT_ACT_H | ||
3 | |||
4 | #include <asm/uaccess.h> | ||
5 | #include <asm/system.h> | ||
6 | #include <linux/bitops.h> | ||
7 | #include <linux/types.h> | ||
8 | #include <linux/kernel.h> | ||
9 | #include <linux/sched.h> | ||
10 | #include <linux/string.h> | ||
11 | #include <linux/mm.h> | ||
12 | #include <linux/socket.h> | ||
13 | #include <linux/sockios.h> | ||
14 | #include <linux/in.h> | ||
15 | #include <linux/errno.h> | ||
16 | #include <linux/interrupt.h> | ||
17 | #include <linux/skbuff.h> | ||
18 | #include <linux/rtnetlink.h> | ||
19 | #include <linux/module.h> | ||
20 | #include <linux/init.h> | ||
21 | #include <linux/proc_fs.h> | ||
22 | #include <net/sock.h> | ||
23 | #include <net/pkt_sched.h> | ||
24 | |||
25 | #define tca_st(val) (struct tcf_##val *) | ||
26 | #define PRIV(a,name) ( tca_st(name) (a)->priv) | ||
27 | |||
28 | #if 0 /* control */ | ||
29 | #define DPRINTK(format,args...) printk(KERN_DEBUG format,##args) | ||
30 | #else | ||
31 | #define DPRINTK(format,args...) | ||
32 | #endif | ||
33 | |||
34 | #if 0 /* data */ | ||
35 | #define D2PRINTK(format,args...) printk(KERN_DEBUG format,##args) | ||
36 | #else | ||
37 | #define D2PRINTK(format,args...) | ||
38 | #endif | ||
39 | |||
40 | static __inline__ unsigned | ||
41 | tcf_hash(u32 index) | ||
42 | { | ||
43 | return index & MY_TAB_MASK; | ||
44 | } | ||
45 | |||
46 | /* probably move this from being inline | ||
47 | * and put into act_generic | ||
48 | */ | ||
49 | static inline void | ||
50 | tcf_hash_destroy(struct tcf_st *p) | ||
51 | { | ||
52 | unsigned h = tcf_hash(p->index); | ||
53 | struct tcf_st **p1p; | ||
54 | |||
55 | for (p1p = &tcf_ht[h]; *p1p; p1p = &(*p1p)->next) { | ||
56 | if (*p1p == p) { | ||
57 | write_lock_bh(&tcf_t_lock); | ||
58 | *p1p = p->next; | ||
59 | write_unlock_bh(&tcf_t_lock); | ||
60 | #ifdef CONFIG_NET_ESTIMATOR | ||
61 | gen_kill_estimator(&p->bstats, &p->rate_est); | ||
62 | #endif | ||
63 | kfree(p); | ||
64 | return; | ||
65 | } | ||
66 | } | ||
67 | BUG_TRAP(0); | ||
68 | } | ||
69 | |||
70 | static inline int | ||
71 | tcf_hash_release(struct tcf_st *p, int bind ) | ||
72 | { | ||
73 | int ret = 0; | ||
74 | if (p) { | ||
75 | if (bind) { | ||
76 | p->bindcnt--; | ||
77 | } | ||
78 | p->refcnt--; | ||
79 | if(p->bindcnt <=0 && p->refcnt <= 0) { | ||
80 | tcf_hash_destroy(p); | ||
81 | ret = 1; | ||
82 | } | ||
83 | } | ||
84 | return ret; | ||
85 | } | ||
86 | |||
87 | static __inline__ int | ||
88 | tcf_dump_walker(struct sk_buff *skb, struct netlink_callback *cb, | ||
89 | struct tc_action *a) | ||
90 | { | ||
91 | struct tcf_st *p; | ||
92 | int err =0, index = -1,i= 0, s_i = 0, n_i = 0; | ||
93 | struct rtattr *r ; | ||
94 | |||
95 | read_lock(&tcf_t_lock); | ||
96 | |||
97 | s_i = cb->args[0]; | ||
98 | |||
99 | for (i = 0; i < MY_TAB_SIZE; i++) { | ||
100 | p = tcf_ht[tcf_hash(i)]; | ||
101 | |||
102 | for (; p; p = p->next) { | ||
103 | index++; | ||
104 | if (index < s_i) | ||
105 | continue; | ||
106 | a->priv = p; | ||
107 | a->order = n_i; | ||
108 | r = (struct rtattr*) skb->tail; | ||
109 | RTA_PUT(skb, a->order, 0, NULL); | ||
110 | err = tcf_action_dump_1(skb, a, 0, 0); | ||
111 | if (0 > err) { | ||
112 | index--; | ||
113 | skb_trim(skb, (u8*)r - skb->data); | ||
114 | goto done; | ||
115 | } | ||
116 | r->rta_len = skb->tail - (u8*)r; | ||
117 | n_i++; | ||
118 | if (n_i >= TCA_ACT_MAX_PRIO) { | ||
119 | goto done; | ||
120 | } | ||
121 | } | ||
122 | } | ||
123 | done: | ||
124 | read_unlock(&tcf_t_lock); | ||
125 | if (n_i) | ||
126 | cb->args[0] += n_i; | ||
127 | return n_i; | ||
128 | |||
129 | rtattr_failure: | ||
130 | skb_trim(skb, (u8*)r - skb->data); | ||
131 | goto done; | ||
132 | } | ||
133 | |||
134 | static __inline__ int | ||
135 | tcf_del_walker(struct sk_buff *skb, struct tc_action *a) | ||
136 | { | ||
137 | struct tcf_st *p, *s_p; | ||
138 | struct rtattr *r ; | ||
139 | int i= 0, n_i = 0; | ||
140 | |||
141 | r = (struct rtattr*) skb->tail; | ||
142 | RTA_PUT(skb, a->order, 0, NULL); | ||
143 | RTA_PUT(skb, TCA_KIND, IFNAMSIZ, a->ops->kind); | ||
144 | for (i = 0; i < MY_TAB_SIZE; i++) { | ||
145 | p = tcf_ht[tcf_hash(i)]; | ||
146 | |||
147 | while (p != NULL) { | ||
148 | s_p = p->next; | ||
149 | if (ACT_P_DELETED == tcf_hash_release(p, 0)) { | ||
150 | module_put(a->ops->owner); | ||
151 | } | ||
152 | n_i++; | ||
153 | p = s_p; | ||
154 | } | ||
155 | } | ||
156 | RTA_PUT(skb, TCA_FCNT, 4, &n_i); | ||
157 | r->rta_len = skb->tail - (u8*)r; | ||
158 | |||
159 | return n_i; | ||
160 | rtattr_failure: | ||
161 | skb_trim(skb, (u8*)r - skb->data); | ||
162 | return -EINVAL; | ||
163 | } | ||
164 | |||
165 | static __inline__ int | ||
166 | tcf_generic_walker(struct sk_buff *skb, struct netlink_callback *cb, int type, | ||
167 | struct tc_action *a) | ||
168 | { | ||
169 | if (type == RTM_DELACTION) { | ||
170 | return tcf_del_walker(skb,a); | ||
171 | } else if (type == RTM_GETACTION) { | ||
172 | return tcf_dump_walker(skb,cb,a); | ||
173 | } else { | ||
174 | printk("tcf_generic_walker: unknown action %d\n",type); | ||
175 | return -EINVAL; | ||
176 | } | ||
177 | } | ||
178 | |||
179 | static __inline__ struct tcf_st * | ||
180 | tcf_hash_lookup(u32 index) | ||
181 | { | ||
182 | struct tcf_st *p; | ||
183 | |||
184 | read_lock(&tcf_t_lock); | ||
185 | for (p = tcf_ht[tcf_hash(index)]; p; p = p->next) { | ||
186 | if (p->index == index) | ||
187 | break; | ||
188 | } | ||
189 | read_unlock(&tcf_t_lock); | ||
190 | return p; | ||
191 | } | ||
192 | |||
193 | static __inline__ u32 | ||
194 | tcf_hash_new_index(void) | ||
195 | { | ||
196 | do { | ||
197 | if (++idx_gen == 0) | ||
198 | idx_gen = 1; | ||
199 | } while (tcf_hash_lookup(idx_gen)); | ||
200 | |||
201 | return idx_gen; | ||
202 | } | ||
203 | |||
204 | |||
205 | static inline int | ||
206 | tcf_hash_search(struct tc_action *a, u32 index) | ||
207 | { | ||
208 | struct tcf_st *p = tcf_hash_lookup(index); | ||
209 | |||
210 | if (p != NULL) { | ||
211 | a->priv = p; | ||
212 | return 1; | ||
213 | } | ||
214 | return 0; | ||
215 | } | ||
216 | |||
217 | #ifdef CONFIG_NET_ACT_INIT | ||
218 | static inline struct tcf_st * | ||
219 | tcf_hash_check(u32 index, struct tc_action *a, int ovr, int bind) | ||
220 | { | ||
221 | struct tcf_st *p = NULL; | ||
222 | if (index && (p = tcf_hash_lookup(index)) != NULL) { | ||
223 | if (bind) { | ||
224 | p->bindcnt++; | ||
225 | p->refcnt++; | ||
226 | } | ||
227 | a->priv = p; | ||
228 | } | ||
229 | return p; | ||
230 | } | ||
231 | |||
232 | static inline struct tcf_st * | ||
233 | tcf_hash_create(u32 index, struct rtattr *est, struct tc_action *a, int size, int ovr, int bind) | ||
234 | { | ||
235 | struct tcf_st *p = NULL; | ||
236 | |||
237 | p = kmalloc(size, GFP_KERNEL); | ||
238 | if (p == NULL) | ||
239 | return p; | ||
240 | |||
241 | memset(p, 0, size); | ||
242 | p->refcnt = 1; | ||
243 | |||
244 | if (bind) { | ||
245 | p->bindcnt = 1; | ||
246 | } | ||
247 | |||
248 | spin_lock_init(&p->lock); | ||
249 | p->stats_lock = &p->lock; | ||
250 | p->index = index ? : tcf_hash_new_index(); | ||
251 | p->tm.install = jiffies; | ||
252 | p->tm.lastuse = jiffies; | ||
253 | #ifdef CONFIG_NET_ESTIMATOR | ||
254 | if (est) | ||
255 | gen_new_estimator(&p->bstats, &p->rate_est, p->stats_lock, est); | ||
256 | #endif | ||
257 | a->priv = (void *) p; | ||
258 | return p; | ||
259 | } | ||
260 | |||
261 | static inline void tcf_hash_insert(struct tcf_st *p) | ||
262 | { | ||
263 | unsigned h = tcf_hash(p->index); | ||
264 | |||
265 | write_lock_bh(&tcf_t_lock); | ||
266 | p->next = tcf_ht[h]; | ||
267 | tcf_ht[h] = p; | ||
268 | write_unlock_bh(&tcf_t_lock); | ||
269 | } | ||
270 | |||
271 | #endif | ||
272 | |||
273 | #endif | ||
diff --git a/include/net/tc_act/tc_defact.h b/include/net/tc_act/tc_defact.h index 463aa671f95d..65f024b80958 100644 --- a/include/net/tc_act/tc_defact.h +++ b/include/net/tc_act/tc_defact.h | |||
@@ -3,11 +3,12 @@ | |||
3 | 3 | ||
4 | #include <net/act_api.h> | 4 | #include <net/act_api.h> |
5 | 5 | ||
6 | struct tcf_defact | 6 | struct tcf_defact { |
7 | { | 7 | struct tcf_common common; |
8 | tca_gen(defact); | 8 | u32 tcfd_datalen; |
9 | u32 datalen; | 9 | void *tcfd_defdata; |
10 | void *defdata; | ||
11 | }; | 10 | }; |
11 | #define to_defact(pc) \ | ||
12 | container_of(pc, struct tcf_defact, common) | ||
12 | 13 | ||
13 | #endif | 14 | #endif /* __NET_TC_DEF_H */ |
diff --git a/include/net/tc_act/tc_gact.h b/include/net/tc_act/tc_gact.h index 59f0d9628ad1..9e3f6767b80e 100644 --- a/include/net/tc_act/tc_gact.h +++ b/include/net/tc_act/tc_gact.h | |||
@@ -3,15 +3,15 @@ | |||
3 | 3 | ||
4 | #include <net/act_api.h> | 4 | #include <net/act_api.h> |
5 | 5 | ||
6 | struct tcf_gact | 6 | struct tcf_gact { |
7 | { | 7 | struct tcf_common common; |
8 | tca_gen(gact); | ||
9 | #ifdef CONFIG_GACT_PROB | 8 | #ifdef CONFIG_GACT_PROB |
10 | u16 ptype; | 9 | u16 tcfg_ptype; |
11 | u16 pval; | 10 | u16 tcfg_pval; |
12 | int paction; | 11 | int tcfg_paction; |
13 | #endif | 12 | #endif |
14 | |||
15 | }; | 13 | }; |
16 | 14 | #define to_gact(pc) \ | |
17 | #endif | 15 | container_of(pc, struct tcf_gact, common) |
16 | |||
17 | #endif /* __NET_TC_GACT_H */ | ||
diff --git a/include/net/tc_act/tc_ipt.h b/include/net/tc_act/tc_ipt.h index cb37ad08427f..f7d25dfcc4b7 100644 --- a/include/net/tc_act/tc_ipt.h +++ b/include/net/tc_act/tc_ipt.h | |||
@@ -5,12 +5,13 @@ | |||
5 | 5 | ||
6 | struct xt_entry_target; | 6 | struct xt_entry_target; |
7 | 7 | ||
8 | struct tcf_ipt | 8 | struct tcf_ipt { |
9 | { | 9 | struct tcf_common common; |
10 | tca_gen(ipt); | 10 | u32 tcfi_hook; |
11 | u32 hook; | 11 | char *tcfi_tname; |
12 | char *tname; | 12 | struct xt_entry_target *tcfi_t; |
13 | struct xt_entry_target *t; | ||
14 | }; | 13 | }; |
14 | #define to_ipt(pc) \ | ||
15 | container_of(pc, struct tcf_ipt, common) | ||
15 | 16 | ||
16 | #endif | 17 | #endif /* __NET_TC_IPT_H */ |
diff --git a/include/net/tc_act/tc_mirred.h b/include/net/tc_act/tc_mirred.h index b5c32f65c12c..ceac661cdfd5 100644 --- a/include/net/tc_act/tc_mirred.h +++ b/include/net/tc_act/tc_mirred.h | |||
@@ -3,13 +3,14 @@ | |||
3 | 3 | ||
4 | #include <net/act_api.h> | 4 | #include <net/act_api.h> |
5 | 5 | ||
6 | struct tcf_mirred | 6 | struct tcf_mirred { |
7 | { | 7 | struct tcf_common common; |
8 | tca_gen(mirred); | 8 | int tcfm_eaction; |
9 | int eaction; | 9 | int tcfm_ifindex; |
10 | int ifindex; | 10 | int tcfm_ok_push; |
11 | int ok_push; | 11 | struct net_device *tcfm_dev; |
12 | struct net_device *dev; | ||
13 | }; | 12 | }; |
13 | #define to_mirred(pc) \ | ||
14 | container_of(pc, struct tcf_mirred, common) | ||
14 | 15 | ||
15 | #endif | 16 | #endif /* __NET_TC_MIR_H */ |
diff --git a/include/net/tc_act/tc_pedit.h b/include/net/tc_act/tc_pedit.h index eb21689d759d..e6f6e15956f5 100644 --- a/include/net/tc_act/tc_pedit.h +++ b/include/net/tc_act/tc_pedit.h | |||
@@ -3,12 +3,13 @@ | |||
3 | 3 | ||
4 | #include <net/act_api.h> | 4 | #include <net/act_api.h> |
5 | 5 | ||
6 | struct tcf_pedit | 6 | struct tcf_pedit { |
7 | { | 7 | struct tcf_common common; |
8 | tca_gen(pedit); | 8 | unsigned char tcfp_nkeys; |
9 | unsigned char nkeys; | 9 | unsigned char tcfp_flags; |
10 | unsigned char flags; | 10 | struct tc_pedit_key *tcfp_keys; |
11 | struct tc_pedit_key *keys; | ||
12 | }; | 11 | }; |
12 | #define to_pedit(pc) \ | ||
13 | container_of(pc, struct tcf_pedit, common) | ||
13 | 14 | ||
14 | #endif | 15 | #endif /* __NET_TC_PED_H */ |