diff options
author | Vlad Yasevich <vladislav.yasevich@hp.com> | 2009-02-13 03:33:43 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-02-16 03:03:10 -0500 |
commit | faee47cdbfe8d74a1573c2f81ea6dbb08d735be6 (patch) | |
tree | 6a95e8f91087cd3d584fc89f9bc06355d371d82a /include/net/sctp | |
parent | 4458f04c02a46c679a90ef71f866a415c192deb4 (diff) |
sctp: Fix the RTO-doubling on idle-link heartbeats
SCTP incorrectly doubles rto ever time a Hearbeat chunk
is generated. However RFC 4960 states:
On an idle destination address that is allowed to heartbeat, it is
recommended that a HEARTBEAT chunk is sent once per RTO of that
destination address plus the protocol parameter 'HB.interval', with
jittering of +/- 50% of the RTO value, and exponential backoff of the
RTO if the previous HEARTBEAT is unanswered.
Essentially, of if the heartbean is unacknowledged, do we double the RTO.
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/sctp')
-rw-r--r-- | include/net/sctp/structs.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h index 9f70d54fcefc..23f08fe1d50a 100644 --- a/include/net/sctp/structs.h +++ b/include/net/sctp/structs.h | |||
@@ -910,8 +910,10 @@ struct sctp_transport { | |||
910 | * should be set. Every time the RTT | 910 | * should be set. Every time the RTT |
911 | * calculation completes (i.e. the DATA chunk | 911 | * calculation completes (i.e. the DATA chunk |
912 | * is SACK'd) clear this flag. | 912 | * is SACK'd) clear this flag. |
913 | * hb_sent : a flag that signals that we have a pending heartbeat. | ||
913 | */ | 914 | */ |
914 | __u8 rto_pending; | 915 | __u8 rto_pending; |
916 | __u8 hb_sent; | ||
915 | 917 | ||
916 | /* Flag to track the current fast recovery state */ | 918 | /* Flag to track the current fast recovery state */ |
917 | __u8 fast_recovery; | 919 | __u8 fast_recovery; |