aboutsummaryrefslogtreecommitdiffstats
path: root/include/net/mac80211.h
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2011-02-24 08:42:06 -0500
committerJohn W. Linville <linville@tuxdriver.com>2011-02-25 15:32:34 -0500
commit7bb4568372856688bc070917265bce0b88bb7d4d (patch)
treee3ca3e7d233944bbc271c650c8b037c3a6652d98 /include/net/mac80211.h
parent43f12d47f0580e04e26c14c03cb19cea9687854e (diff)
mac80211: make tx() operation return void
The return value of the tx operation is commonly misused by drivers, leading to errors. All drivers will drop frames if they fail to TX the frame, and they must also properly manage the queues (if they didn't, mac80211 would already warn). Removing the ability for drivers to return a BUSY value also allows significant cleanups of the TX TX handling code in mac80211. Note that this also fixes a bug in ath9k_htc, the old "return -1" there was wrong. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Tested-by: Sedat Dilek <sedat.dilek@googlemail.com> [ath5k] Acked-by: Gertjan van Wingerde <gwingerde@gmail.com> [rt2x00] Acked-by: Larry Finger <Larry.Finger@lwfinger.net> [b43, rtl8187, rtlwifi] Acked-by: Luciano Coelho <coelho@ti.com> [wl12xx] Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'include/net/mac80211.h')
-rw-r--r--include/net/mac80211.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index a13c8d8fca5c..96cc7ed35169 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -1801,7 +1801,7 @@ enum ieee80211_ampdu_mlme_action {
1801 * aborted before it expires. This callback may sleep. 1801 * aborted before it expires. This callback may sleep.
1802 */ 1802 */
1803struct ieee80211_ops { 1803struct ieee80211_ops {
1804 int (*tx)(struct ieee80211_hw *hw, struct sk_buff *skb); 1804 void (*tx)(struct ieee80211_hw *hw, struct sk_buff *skb);
1805 int (*start)(struct ieee80211_hw *hw); 1805 int (*start)(struct ieee80211_hw *hw);
1806 void (*stop)(struct ieee80211_hw *hw); 1806 void (*stop)(struct ieee80211_hw *hw);
1807 int (*add_interface)(struct ieee80211_hw *hw, 1807 int (*add_interface)(struct ieee80211_hw *hw,