diff options
author | Atsushi Nemoto <anemo@mba.ocn.ne.jp> | 2007-01-24 01:43:34 -0500 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2007-01-24 14:23:22 -0500 |
commit | 66218da212bf141532d678a699f5789c78145ab1 (patch) | |
tree | 6ba949af13a6f07ceaa7a5e99c71dc513d860849 /include/net/dst.h | |
parent | 9cfdf6f15a2a462b6b328b4c60b252cfc04ec03e (diff) |
[MIPS] Fix wrong checksum calculation on 64-bit MIPS
The commit 8e3d8433d8c22ca6c42cba4a67d300c39aae7822 ([NET]: MIPS
checksum annotations and cleanups) broke 64-bit MIPS.
The problem is the commit replaces some unsigned long with __be32. On
64bit MIPS, a __be32 (i.e. unsigned int) value is represented as a
sign-extented 32-bit value in a 64-bit argument register. So the
address 192.168.0.1 (0xc0a80001) is passed as 0xffffffffc0a80001 to
csum_tcpudp_nofold() but the asm code in the function expects
0x00000000c0a80001, therefore it returns a wrong checksum. Explicit
cast to unsigned long is needed to drop high 32bit.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'include/net/dst.h')
0 files changed, 0 insertions, 0 deletions