diff options
author | Mat Martineau <mathewm@codeaurora.org> | 2012-05-18 00:14:09 -0400 |
---|---|---|
committer | Johan Hedberg <johan.hedberg@intel.com> | 2012-06-04 23:34:02 -0400 |
commit | 2827011f666e157f3307d55070a75e1d1110b194 (patch) | |
tree | 5f1fc5b4d102a641cd1c84183440a841540fb6eb /include/net/bluetooth | |
parent | 9dc9affcb776b75f6d3e5d69d6e2a679407854f1 (diff) |
Bluetooth: Fix early return from l2cap_chan_del
This fixes a regression from commit
2ead70b8390d199ca04cd35311b51f5f3676079e that is present in all
kernels starting at v3.0.
When L2CAP information was moved to struct l2cap_chan, a check was
added to l2cap_chan_del to avoid certain cleanup operations when ERTM
or streaming mode had not yet been initialized. The logic in the
check did not take in to account that chan->conf_state is set to 0 in
l2cap_chan_ready, so l2cap_chan_del failed to cancel timers and leaked
memory any time the ERTM queues or lists were not empty.
This change makes sure that l2cap_chan_del only returns early if
ERTM initialization was not performed.
Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'include/net/bluetooth')
-rw-r--r-- | include/net/bluetooth/l2cap.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h index 1c7d1cd5e679..452fcc4c0fff 100644 --- a/include/net/bluetooth/l2cap.h +++ b/include/net/bluetooth/l2cap.h | |||
@@ -597,6 +597,7 @@ enum { | |||
597 | CONF_EWS_RECV, | 597 | CONF_EWS_RECV, |
598 | CONF_LOC_CONF_PEND, | 598 | CONF_LOC_CONF_PEND, |
599 | CONF_REM_CONF_PEND, | 599 | CONF_REM_CONF_PEND, |
600 | CONF_NOT_COMPLETE, | ||
600 | }; | 601 | }; |
601 | 602 | ||
602 | #define L2CAP_CONF_MAX_CONF_REQ 2 | 603 | #define L2CAP_CONF_MAX_CONF_REQ 2 |