diff options
author | Hans Verkuil <hans.verkuil@cisco.com> | 2014-11-18 07:50:58 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2014-11-25 05:50:28 -0500 |
commit | cd474037c4a9a9c15cab46ff26ceeed1bbda6abb (patch) | |
tree | 17ce0741bc7879d60ca83c116afdf73254cb35e4 /include/media/videobuf2-core.h | |
parent | cf227429c74778cc9f8caf734d1f161f8f021915 (diff) |
[media] vb2: replace 'write' by 'dma_dir'
The 'write' argument is very ambiguous. I first assumed that if it is 1,
then we're doing video output but instead it meant the reverse.
Since it is used to setup the dma_dir value anyway it is now replaced by
the correct dma_dir value which is unambiguous.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Pawel Osciak <pawel@osciak.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'include/media/videobuf2-core.h')
-rw-r--r-- | include/media/videobuf2-core.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index 70ace7cc6087..d607871749c7 100644 --- a/include/media/videobuf2-core.h +++ b/include/media/videobuf2-core.h | |||
@@ -87,14 +87,16 @@ struct vb2_mem_ops { | |||
87 | struct dma_buf *(*get_dmabuf)(void *buf_priv, unsigned long flags); | 87 | struct dma_buf *(*get_dmabuf)(void *buf_priv, unsigned long flags); |
88 | 88 | ||
89 | void *(*get_userptr)(void *alloc_ctx, unsigned long vaddr, | 89 | void *(*get_userptr)(void *alloc_ctx, unsigned long vaddr, |
90 | unsigned long size, int write); | 90 | unsigned long size, |
91 | enum dma_data_direction dma_dir); | ||
91 | void (*put_userptr)(void *buf_priv); | 92 | void (*put_userptr)(void *buf_priv); |
92 | 93 | ||
93 | void (*prepare)(void *buf_priv); | 94 | void (*prepare)(void *buf_priv); |
94 | void (*finish)(void *buf_priv); | 95 | void (*finish)(void *buf_priv); |
95 | 96 | ||
96 | void *(*attach_dmabuf)(void *alloc_ctx, struct dma_buf *dbuf, | 97 | void *(*attach_dmabuf)(void *alloc_ctx, struct dma_buf *dbuf, |
97 | unsigned long size, int write); | 98 | unsigned long size, |
99 | enum dma_data_direction dma_dir); | ||
98 | void (*detach_dmabuf)(void *buf_priv); | 100 | void (*detach_dmabuf)(void *buf_priv); |
99 | int (*map_dmabuf)(void *buf_priv); | 101 | int (*map_dmabuf)(void *buf_priv); |
100 | void (*unmap_dmabuf)(void *buf_priv); | 102 | void (*unmap_dmabuf)(void *buf_priv); |