diff options
author | Boaz Harrosh <bharrosh@panasas.com> | 2009-12-03 13:28:59 -0500 |
---|---|---|
committer | J. Bruce Fields <bfields@citi.umich.edu> | 2009-12-14 18:12:09 -0500 |
commit | 72579ac9cd68081108277c31781b127d0f420d61 (patch) | |
tree | de5e45c4a7928794ee843dc0f1b08ea16e8b350a /include/linux | |
parent | d703158229329af7152d159753f849aa7bd55ee6 (diff) |
nfsd: Headers Independence and include cleanups
* Add includes that are directly used by headers
* Remove includes that are not needed
These are the changes made:
[xdr.h]
struct nfsd_readdirres has an embedded struct readdir_cd from nfsd.h
fixing that we can drop other includes
[xdr4.h]
embedded types defined both at state.h and nfsd.h
[syscall.h]
After export.h fix none of these stuff is needed.
fix extra space in # include <> statement
[stats.h]
does not need <linux/nfs4.h> but was export to user-mode
so I don't touch it
[state.h]
embedded types from nfsfh.h like struct knfsd_fh. bringing that
eliminates the need for all other includes
[nfsfh.h]
directly manipulating types from sunrpc/svc.h.
Removed Other unused headers.
[nfsd.h]
removed unused headers include
[export.h]
lots of sunrpc/svc.h types and a single prototype declaration
with pointer from nfsfh.h, but all users of export.h do need
nfsfh.h any way. remove now un-needed include.
[const.h]
Unfixed (not independent)
[cache.h]
could do with a forward declaration of "struct svc_rqst;"
from sunrpc/svc.h but all users absolutely will need
sunrpc/svc.h it is easier overall this way.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'include/linux')
-rw-r--r-- | include/linux/nfsd/cache.h | 3 | ||||
-rw-r--r-- | include/linux/nfsd/export.h | 2 | ||||
-rw-r--r-- | include/linux/nfsd/nfsd.h | 4 | ||||
-rw-r--r-- | include/linux/nfsd/nfsfh.h | 3 | ||||
-rw-r--r-- | include/linux/nfsd/state.h | 4 | ||||
-rw-r--r-- | include/linux/nfsd/syscall.h | 8 | ||||
-rw-r--r-- | include/linux/nfsd/xdr.h | 3 | ||||
-rw-r--r-- | include/linux/nfsd/xdr4.h | 3 |
8 files changed, 8 insertions, 22 deletions
diff --git a/include/linux/nfsd/cache.h b/include/linux/nfsd/cache.h index 3a3f58934f5e..a165425dea41 100644 --- a/include/linux/nfsd/cache.h +++ b/include/linux/nfsd/cache.h | |||
@@ -10,8 +10,7 @@ | |||
10 | #ifndef NFSCACHE_H | 10 | #ifndef NFSCACHE_H |
11 | #define NFSCACHE_H | 11 | #define NFSCACHE_H |
12 | 12 | ||
13 | #include <linux/in.h> | 13 | #include <linux/sunrpc/svc.h> |
14 | #include <linux/uio.h> | ||
15 | 14 | ||
16 | /* | 15 | /* |
17 | * Representation of a reply cache entry. | 16 | * Representation of a reply cache entry. |
diff --git a/include/linux/nfsd/export.h b/include/linux/nfsd/export.h index a6d9ef2bb34a..ef3d416fcf67 100644 --- a/include/linux/nfsd/export.h +++ b/include/linux/nfsd/export.h | |||
@@ -12,7 +12,7 @@ | |||
12 | 12 | ||
13 | # include <linux/types.h> | 13 | # include <linux/types.h> |
14 | #ifdef __KERNEL__ | 14 | #ifdef __KERNEL__ |
15 | # include <linux/in.h> | 15 | # include <linux/nfsd/nfsfh.h> |
16 | #endif | 16 | #endif |
17 | 17 | ||
18 | /* | 18 | /* |
diff --git a/include/linux/nfsd/nfsd.h b/include/linux/nfsd/nfsd.h index e4518d090a8c..74f67c2aca34 100644 --- a/include/linux/nfsd/nfsd.h +++ b/include/linux/nfsd/nfsd.h | |||
@@ -11,13 +11,9 @@ | |||
11 | #define LINUX_NFSD_NFSD_H | 11 | #define LINUX_NFSD_NFSD_H |
12 | 12 | ||
13 | #include <linux/types.h> | 13 | #include <linux/types.h> |
14 | #include <linux/unistd.h> | ||
15 | #include <linux/fs.h> | ||
16 | #include <linux/posix_acl.h> | ||
17 | #include <linux/mount.h> | 14 | #include <linux/mount.h> |
18 | 15 | ||
19 | #include <linux/nfsd/debug.h> | 16 | #include <linux/nfsd/debug.h> |
20 | #include <linux/nfsd/nfsfh.h> | ||
21 | #include <linux/nfsd/export.h> | 17 | #include <linux/nfsd/export.h> |
22 | #include <linux/nfsd/stats.h> | 18 | #include <linux/nfsd/stats.h> |
23 | /* | 19 | /* |
diff --git a/include/linux/nfsd/nfsfh.h b/include/linux/nfsd/nfsfh.h index 2973e1135343..49523edbc510 100644 --- a/include/linux/nfsd/nfsfh.h +++ b/include/linux/nfsd/nfsfh.h | |||
@@ -16,8 +16,7 @@ | |||
16 | 16 | ||
17 | # include <linux/types.h> | 17 | # include <linux/types.h> |
18 | #ifdef __KERNEL__ | 18 | #ifdef __KERNEL__ |
19 | # include <linux/string.h> | 19 | # include <linux/sunrpc/svc.h> |
20 | # include <linux/fs.h> | ||
21 | #endif | 20 | #endif |
22 | #include <linux/nfsd/const.h> | 21 | #include <linux/nfsd/const.h> |
23 | 22 | ||
diff --git a/include/linux/nfsd/state.h b/include/linux/nfsd/state.h index 5aadf8aa3a97..2af75686e0d3 100644 --- a/include/linux/nfsd/state.h +++ b/include/linux/nfsd/state.h | |||
@@ -37,9 +37,7 @@ | |||
37 | #ifndef _NFSD4_STATE_H | 37 | #ifndef _NFSD4_STATE_H |
38 | #define _NFSD4_STATE_H | 38 | #define _NFSD4_STATE_H |
39 | 39 | ||
40 | #include <linux/list.h> | 40 | #include <linux/nfsd/nfsfh.h> |
41 | #include <linux/kref.h> | ||
42 | #include <linux/sunrpc/clnt.h> | ||
43 | 41 | ||
44 | typedef struct { | 42 | typedef struct { |
45 | u32 cl_boot; | 43 | u32 cl_boot; |
diff --git a/include/linux/nfsd/syscall.h b/include/linux/nfsd/syscall.h index 7a3b565b898f..812bc1e160dc 100644 --- a/include/linux/nfsd/syscall.h +++ b/include/linux/nfsd/syscall.h | |||
@@ -9,14 +9,8 @@ | |||
9 | #ifndef NFSD_SYSCALL_H | 9 | #ifndef NFSD_SYSCALL_H |
10 | #define NFSD_SYSCALL_H | 10 | #define NFSD_SYSCALL_H |
11 | 11 | ||
12 | # include <linux/types.h> | 12 | #include <linux/types.h> |
13 | #ifdef __KERNEL__ | ||
14 | # include <linux/in.h> | ||
15 | #endif | ||
16 | #include <linux/posix_types.h> | ||
17 | #include <linux/nfsd/const.h> | ||
18 | #include <linux/nfsd/export.h> | 13 | #include <linux/nfsd/export.h> |
19 | #include <linux/nfsd/nfsfh.h> | ||
20 | 14 | ||
21 | /* | 15 | /* |
22 | * Version of the syscall interface | 16 | * Version of the syscall interface |
diff --git a/include/linux/nfsd/xdr.h b/include/linux/nfsd/xdr.h index a0132ef58f21..58f824d854c2 100644 --- a/include/linux/nfsd/xdr.h +++ b/include/linux/nfsd/xdr.h | |||
@@ -7,9 +7,8 @@ | |||
7 | #ifndef LINUX_NFSD_H | 7 | #ifndef LINUX_NFSD_H |
8 | #define LINUX_NFSD_H | 8 | #define LINUX_NFSD_H |
9 | 9 | ||
10 | #include <linux/fs.h> | ||
11 | #include <linux/vfs.h> | 10 | #include <linux/vfs.h> |
12 | #include <linux/nfs.h> | 11 | #include <linux/nfsd/nfsd.h> |
13 | 12 | ||
14 | struct nfsd_fhandle { | 13 | struct nfsd_fhandle { |
15 | struct svc_fh fh; | 14 | struct svc_fh fh; |
diff --git a/include/linux/nfsd/xdr4.h b/include/linux/nfsd/xdr4.h index 73164c2b3d29..1bf266239c7e 100644 --- a/include/linux/nfsd/xdr4.h +++ b/include/linux/nfsd/xdr4.h | |||
@@ -39,7 +39,8 @@ | |||
39 | #ifndef _LINUX_NFSD_XDR4_H | 39 | #ifndef _LINUX_NFSD_XDR4_H |
40 | #define _LINUX_NFSD_XDR4_H | 40 | #define _LINUX_NFSD_XDR4_H |
41 | 41 | ||
42 | #include <linux/nfs4.h> | 42 | #include <linux/nfsd/state.h> |
43 | #include <linux/nfsd/nfsd.h> | ||
43 | 44 | ||
44 | #define NFSD4_MAX_TAGLEN 128 | 45 | #define NFSD4_MAX_TAGLEN 128 |
45 | #define XDR_LEN(n) (((n) + 3) & ~3) | 46 | #define XDR_LEN(n) (((n) + 3) & ~3) |