diff options
author | David Howells <dhowells@redhat.com> | 2008-11-13 18:39:19 -0500 |
---|---|---|
committer | James Morris <jmorris@namei.org> | 2008-11-13 18:39:19 -0500 |
commit | c69e8d9c01db2adc503464993c358901c9af9de4 (patch) | |
tree | bed94aaa9aeb7a7834d1c880f72b62a11a752c78 /include/linux | |
parent | 86a264abe542cfececb4df129bc45a0338d8cdb9 (diff) |
CRED: Use RCU to access another task's creds and to release a task's own creds
Use RCU to access another task's creds and to release a task's own creds.
This means that it will be possible for the credentials of a task to be
replaced without another task (a) requiring a full lock to read them, and (b)
seeing deallocated memory.
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: James Morris <jmorris@namei.org>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'include/linux')
-rw-r--r-- | include/linux/cred.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/cred.h b/include/linux/cred.h index 4221ec6000c1..166ce4ddba64 100644 --- a/include/linux/cred.h +++ b/include/linux/cred.h | |||
@@ -147,8 +147,9 @@ static inline struct cred *get_cred(struct cred *cred) | |||
147 | * Release a reference to a set of credentials, deleting them when the last ref | 147 | * Release a reference to a set of credentials, deleting them when the last ref |
148 | * is released. | 148 | * is released. |
149 | */ | 149 | */ |
150 | static inline void put_cred(struct cred *cred) | 150 | static inline void put_cred(const struct cred *_cred) |
151 | { | 151 | { |
152 | struct cred *cred = (struct cred *) _cred; | ||
152 | if (atomic_dec_and_test(&(cred)->usage)) | 153 | if (atomic_dec_and_test(&(cred)->usage)) |
153 | __put_cred(cred); | 154 | __put_cred(cred); |
154 | } | 155 | } |