diff options
author | Tom Zanussi <tzanussi@gmail.com> | 2009-04-28 04:04:53 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-04-29 08:06:03 -0400 |
commit | a118e4d1402f1349fe3d953493e4168a300a752d (patch) | |
tree | bd4c2fccee4528bf7d1536e33218516953904740 /include/linux | |
parent | 30e673b230f9d556eb81ef68a7b1a08c8b3b142c (diff) |
tracing/filters: distinguish between signed and unsigned fields
The new filter comparison ops need to be able to distinguish between
signed and unsigned field types, so add an is_signed flag/param to the
event field struct/trace_define_fields(). Also define a simple macro,
is_signed_type() to determine the signedness at compile time, used in the
trace macros. If the is_signed_type() macro won't work with a specific
type, a new slightly modified version of TRACE_FIELD() called
TRACE_FIELD_SIGN(), allows the signedness to be set explicitly.
[ Impact: extend trace-filter code for new feature ]
Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: fweisbec@gmail.com
Cc: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <1240905893.6416.120.camel@tropicana>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'include/linux')
-rw-r--r-- | include/linux/ftrace_event.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h index 46a27f2695a6..e61a7403f3d0 100644 --- a/include/linux/ftrace_event.h +++ b/include/linux/ftrace_event.h | |||
@@ -122,8 +122,9 @@ extern int filter_current_check_discard(struct ftrace_event_call *call, | |||
122 | struct ring_buffer_event *event); | 122 | struct ring_buffer_event *event); |
123 | 123 | ||
124 | extern int trace_define_field(struct ftrace_event_call *call, char *type, | 124 | extern int trace_define_field(struct ftrace_event_call *call, char *type, |
125 | char *name, int offset, int size); | 125 | char *name, int offset, int size, int is_signed); |
126 | 126 | ||
127 | #define is_signed_type(type) (((type)(-1)) < 0) | ||
127 | 128 | ||
128 | /* | 129 | /* |
129 | * The double __builtin_constant_p is because gcc will give us an error | 130 | * The double __builtin_constant_p is because gcc will give us an error |
@@ -144,10 +145,10 @@ do { \ | |||
144 | __trace_printk(ip, fmt, ##args); \ | 145 | __trace_printk(ip, fmt, ##args); \ |
145 | } while (0) | 146 | } while (0) |
146 | 147 | ||
147 | #define __common_field(type, item) \ | 148 | #define __common_field(type, item, is_signed) \ |
148 | ret = trace_define_field(event_call, #type, "common_" #item, \ | 149 | ret = trace_define_field(event_call, #type, "common_" #item, \ |
149 | offsetof(typeof(field.ent), item), \ | 150 | offsetof(typeof(field.ent), item), \ |
150 | sizeof(field.ent.item)); \ | 151 | sizeof(field.ent.item), is_signed); \ |
151 | if (ret) \ | 152 | if (ret) \ |
152 | return ret; | 153 | return ret; |
153 | 154 | ||