diff options
author | Alan Stern <stern@rowland.harvard.edu> | 2009-10-09 12:43:12 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-10-09 16:52:05 -0400 |
commit | a4720c650b68a5fe7faed2edeb0ad12645f7ae63 (patch) | |
tree | 829c32036a25279bb9aa1fc6077af5fa52f8f29e /include/linux | |
parent | ba6b702f85a61561d329c4c11d3ed95604924f9a (diff) |
USB: serial: don't call release without attach
This patch (as1295) fixes a recently-added bug in the USB serial core.
If certain kinds of errors occur during probing, the core may call a
serial driver's release method without previously calling the attach
method. This causes some drivers (io_ti in particular) to perform an
invalid memory access.
The patch adds a new flag to keep track of whether or not attach has
been called.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Tested-by: Jean-Denis Girard <jd.girard@sysnux.pf>
CC: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'include/linux')
-rw-r--r-- | include/linux/usb/serial.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h index c17eb64d7213..ce911ebf91e8 100644 --- a/include/linux/usb/serial.h +++ b/include/linux/usb/serial.h | |||
@@ -150,6 +150,7 @@ struct usb_serial { | |||
150 | struct usb_interface *interface; | 150 | struct usb_interface *interface; |
151 | unsigned char disconnected:1; | 151 | unsigned char disconnected:1; |
152 | unsigned char suspending:1; | 152 | unsigned char suspending:1; |
153 | unsigned char attached:1; | ||
153 | unsigned char minor; | 154 | unsigned char minor; |
154 | unsigned char num_ports; | 155 | unsigned char num_ports; |
155 | unsigned char num_port_pointers; | 156 | unsigned char num_port_pointers; |