diff options
author | David Woodhouse <dwmw2@infradead.org> | 2006-01-11 09:41:26 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-01-11 11:14:16 -0500 |
commit | a4fc7ab1d065a9dd89ed0e74439ef87d4a16e980 (patch) | |
tree | 6312597ad183ee45e8769b1bc5b0035bfa681d64 /include/linux | |
parent | a8b9ee7396ccc8db3bdb4108993556acbe2d3527 (diff) |
[PATCH] fix/simplify mutex debugging code
Let's switch mutex_debug_check_no_locks_freed() to take (addr, len) as
arguments instead, since all its callers were just calculating the 'to'
address for themselves anyway... (and sometimes doing so badly).
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/linux')
-rw-r--r-- | include/linux/mm.h | 2 | ||||
-rw-r--r-- | include/linux/mutex-debug.h | 2 | ||||
-rw-r--r-- | include/linux/mutex.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/include/linux/mm.h b/include/linux/mm.h index 3f1fafc0245e..e53d2c6fd5f4 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h | |||
@@ -1027,7 +1027,7 @@ kernel_map_pages(struct page *page, int numpages, int enable) | |||
1027 | { | 1027 | { |
1028 | if (!PageHighMem(page) && !enable) | 1028 | if (!PageHighMem(page) && !enable) |
1029 | mutex_debug_check_no_locks_freed(page_address(page), | 1029 | mutex_debug_check_no_locks_freed(page_address(page), |
1030 | page_address(page + numpages)); | 1030 | numpages * PAGE_SIZE); |
1031 | } | 1031 | } |
1032 | #endif | 1032 | #endif |
1033 | 1033 | ||
diff --git a/include/linux/mutex-debug.h b/include/linux/mutex-debug.h index 8138d9eb58ec..8b5769f00467 100644 --- a/include/linux/mutex-debug.h +++ b/include/linux/mutex-debug.h | |||
@@ -18,6 +18,6 @@ extern void FASTCALL(mutex_destroy(struct mutex *lock)); | |||
18 | extern void mutex_debug_show_all_locks(void); | 18 | extern void mutex_debug_show_all_locks(void); |
19 | extern void mutex_debug_show_held_locks(struct task_struct *filter); | 19 | extern void mutex_debug_show_held_locks(struct task_struct *filter); |
20 | extern void mutex_debug_check_no_locks_held(struct task_struct *task); | 20 | extern void mutex_debug_check_no_locks_held(struct task_struct *task); |
21 | extern void mutex_debug_check_no_locks_freed(const void *from, const void *to); | 21 | extern void mutex_debug_check_no_locks_freed(const void *from, unsigned long len); |
22 | 22 | ||
23 | #endif | 23 | #endif |
diff --git a/include/linux/mutex.h b/include/linux/mutex.h index f1c84b1252f5..f1ac507fa20d 100644 --- a/include/linux/mutex.h +++ b/include/linux/mutex.h | |||
@@ -79,7 +79,7 @@ struct mutex_waiter { | |||
79 | # define mutex_debug_show_all_locks() do { } while (0) | 79 | # define mutex_debug_show_all_locks() do { } while (0) |
80 | # define mutex_debug_show_held_locks(p) do { } while (0) | 80 | # define mutex_debug_show_held_locks(p) do { } while (0) |
81 | # define mutex_debug_check_no_locks_held(task) do { } while (0) | 81 | # define mutex_debug_check_no_locks_held(task) do { } while (0) |
82 | # define mutex_debug_check_no_locks_freed(from, to) do { } while (0) | 82 | # define mutex_debug_check_no_locks_freed(from, len) do { } while (0) |
83 | #endif | 83 | #endif |
84 | 84 | ||
85 | #define __MUTEX_INITIALIZER(lockname) \ | 85 | #define __MUTEX_INITIALIZER(lockname) \ |