diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-31 14:15:19 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-31 14:15:19 -0400 |
commit | 35c9b4daf4c94b30e5cede597d98016ebf31b5ad (patch) | |
tree | 3248b5b3602218537ce0bce420fbde27a07b526b /include/linux | |
parent | e698ea83a8531a6740dc657329dcf0728392d6ac (diff) |
ide: add ->dma_clear method and remove ->dma_timeout one
All custom ->dma_timeout implementations call the generic one thus it is
possible to have only an optional method for resetting DMA engine instead:
* Add ->dma_clear method and convert hpt366, pdc202xx_old and sl82c105
host drivers to use it.
* Always use ide_dma_timeout() in ide_dma_timeout_retry() and remove
->dma_timeout method.
* Make ide_dma_timeout() static.
There should be no functional changes caused by this patch.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'include/linux')
-rw-r--r-- | include/linux/ide.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/ide.h b/include/linux/ide.h index cb501bf78f7d..d3035f2f1250 100644 --- a/include/linux/ide.h +++ b/include/linux/ide.h | |||
@@ -716,8 +716,9 @@ struct ide_dma_ops { | |||
716 | int (*dma_end)(struct ide_drive_s *); | 716 | int (*dma_end)(struct ide_drive_s *); |
717 | int (*dma_test_irq)(struct ide_drive_s *); | 717 | int (*dma_test_irq)(struct ide_drive_s *); |
718 | void (*dma_lost_irq)(struct ide_drive_s *); | 718 | void (*dma_lost_irq)(struct ide_drive_s *); |
719 | /* below ones are optional */ | ||
719 | int (*dma_timer_expiry)(struct ide_drive_s *); | 720 | int (*dma_timer_expiry)(struct ide_drive_s *); |
720 | void (*dma_timeout)(struct ide_drive_s *); | 721 | void (*dma_clear)(struct ide_drive_s *); |
721 | /* | 722 | /* |
722 | * The following method is optional and only required to be | 723 | * The following method is optional and only required to be |
723 | * implemented for the SFF-8038i compatible controllers. | 724 | * implemented for the SFF-8038i compatible controllers. |
@@ -1461,7 +1462,6 @@ static inline int config_drive_for_dma(ide_drive_t *drive) { return 0; } | |||
1461 | #endif /* CONFIG_BLK_DEV_IDEDMA_SFF */ | 1462 | #endif /* CONFIG_BLK_DEV_IDEDMA_SFF */ |
1462 | 1463 | ||
1463 | void ide_dma_lost_irq(ide_drive_t *); | 1464 | void ide_dma_lost_irq(ide_drive_t *); |
1464 | void ide_dma_timeout(ide_drive_t *); | ||
1465 | ide_startstop_t ide_dma_timeout_retry(ide_drive_t *, int); | 1465 | ide_startstop_t ide_dma_timeout_retry(ide_drive_t *, int); |
1466 | 1466 | ||
1467 | #else | 1467 | #else |