diff options
author | Harvey Harrison <harvey.harrison@gmail.com> | 2008-11-07 01:32:15 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-01-07 12:59:51 -0500 |
commit | d767d888750a8e15656b7ee15d68f90a151b8936 (patch) | |
tree | dff42608d31102b04989ca12352cdcec51e85284 /include/linux/usb | |
parent | d859bffc662482f06ba5603e6f592de4e18cf135 (diff) |
USB: wusb: annotate association types withe proper endianness
Also a trivial annotation in rh.c for:
drivers/usb/wusbcore/rh.c:366:9: warning: incorrect type in assignment (different base types)
drivers/usb/wusbcore/rh.c:366:9: expected unsigned short [unsigned] [short] [usertype] <noident>
drivers/usb/wusbcore/rh.c:366:9: got restricted __le16 [usertype] <noident>
drivers/usb/wusbcore/rh.c:367:9: warning: incorrect type in assignment (different base types)
drivers/usb/wusbcore/rh.c:367:9: expected unsigned short [unsigned] [short] [usertype] <noident>
drivers/usb/wusbcore/rh.c:367:9: got restricted __le16 [usertype] <noident>
Association types annotation fixes piles of warnings similar to:
drivers/usb/wusbcore/cbaf.c:238:30: warning: incorrect type in initializer (different base types)
drivers/usb/wusbcore/cbaf.c:238:30: expected restricted __le16 [usertype] id
drivers/usb/wusbcore/cbaf.c:238:30: got int
drivers/usb/wusbcore/cbaf.c:238:30: warning: incorrect type in initializer (different base types)
drivers/usb/wusbcore/cbaf.c:238:30: expected restricted __le16 [usertype] len
drivers/usb/wusbcore/cbaf.c:238:30: got int
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Cc: David Vrabel <david.vrabel@csr.com>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'include/linux/usb')
-rw-r--r-- | include/linux/usb/association.h | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/include/linux/usb/association.h b/include/linux/usb/association.h index 07c5e3cf5898..0a4a18b3c1bb 100644 --- a/include/linux/usb/association.h +++ b/include/linux/usb/association.h | |||
@@ -28,17 +28,17 @@ struct wusb_am_attr { | |||
28 | }; | 28 | }; |
29 | 29 | ||
30 | /* Different fields defined by the spec */ | 30 | /* Different fields defined by the spec */ |
31 | #define WUSB_AR_AssociationTypeId { .id = 0x0000, .len = 2 } | 31 | #define WUSB_AR_AssociationTypeId { .id = cpu_to_le16(0x0000), .len = cpu_to_le16(2) } |
32 | #define WUSB_AR_AssociationSubTypeId { .id = 0x0001, .len = 2 } | 32 | #define WUSB_AR_AssociationSubTypeId { .id = cpu_to_le16(0x0001), .len = cpu_to_le16(2) } |
33 | #define WUSB_AR_Length { .id = 0x0002, .len = 4 } | 33 | #define WUSB_AR_Length { .id = cpu_to_le16(0x0002), .len = cpu_to_le16(4) } |
34 | #define WUSB_AR_AssociationStatus { .id = 0x0004, .len = 4 } | 34 | #define WUSB_AR_AssociationStatus { .id = cpu_to_le16(0x0004), .len = cpu_to_le16(4) } |
35 | #define WUSB_AR_LangID { .id = 0x0008, .len = 2 } | 35 | #define WUSB_AR_LangID { .id = cpu_to_le16(0x0008), .len = cpu_to_le16(2) } |
36 | #define WUSB_AR_DeviceFriendlyName { .id = 0x000b, .len = 64 } /* max */ | 36 | #define WUSB_AR_DeviceFriendlyName { .id = cpu_to_le16(0x000b), .len = cpu_to_le16(64) } /* max */ |
37 | #define WUSB_AR_HostFriendlyName { .id = 0x000c, .len = 64 } /* max */ | 37 | #define WUSB_AR_HostFriendlyName { .id = cpu_to_le16(0x000c), .len = cpu_to_le16(64) } /* max */ |
38 | #define WUSB_AR_CHID { .id = 0x1000, .len = 16 } | 38 | #define WUSB_AR_CHID { .id = cpu_to_le16(0x1000), .len = cpu_to_le16(16) } |
39 | #define WUSB_AR_CDID { .id = 0x1001, .len = 16 } | 39 | #define WUSB_AR_CDID { .id = cpu_to_le16(0x1001), .len = cpu_to_le16(16) } |
40 | #define WUSB_AR_ConnectionContext { .id = 0x1002, .len = 48 } | 40 | #define WUSB_AR_ConnectionContext { .id = cpu_to_le16(0x1002), .len = cpu_to_le16(48) } |
41 | #define WUSB_AR_BandGroups { .id = 0x1004, .len = 2 } | 41 | #define WUSB_AR_BandGroups { .id = cpu_to_le16(0x1004), .len = cpu_to_le16(2) } |
42 | 42 | ||
43 | /* CBAF Control Requests (AMS1.0[T4-1] */ | 43 | /* CBAF Control Requests (AMS1.0[T4-1] */ |
44 | enum { | 44 | enum { |