aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/ti_wilink_st.h
diff options
context:
space:
mode:
authorPavan Savoy <pavan_savoy@ti.com>2010-10-12 16:27:38 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2010-10-14 15:41:10 -0400
commit73f12e8d3d94828b9efe2b8b8a34b4ad6d14ee47 (patch)
tree42b4dad70d74feccd5c6c802eef6837606096ffe /include/linux/ti_wilink_st.h
parentda6830ac3969c9480e05ed2b21eee64e21a101d2 (diff)
drivers: misc: ti-st: fix review comments
Based on comments from Jiri Slaby, drop the register storage specifier, remove the unused code, cleanup the const to non-const type casting. Also make the line discipline ops structure static, since its a singleton, unmodified structure which need not be in heap. Reported-by: Jiri Slaby <jirislaby@gmail.com> Signed-off-by: Pavan Savoy <pavan_savoy@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'include/linux/ti_wilink_st.h')
-rw-r--r--include/linux/ti_wilink_st.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/include/linux/ti_wilink_st.h b/include/linux/ti_wilink_st.h
index 2a5acf599598..4c7be2263011 100644
--- a/include/linux/ti_wilink_st.h
+++ b/include/linux/ti_wilink_st.h
@@ -101,7 +101,6 @@ extern long st_unregister(enum proto_type);
101 * can occur , where as during other times other events CH8, CH9 101 * can occur , where as during other times other events CH8, CH9
102 * can occur. 102 * can occur.
103 * @tty: tty provided by the TTY core for line disciplines. 103 * @tty: tty provided by the TTY core for line disciplines.
104 * @ldisc_ops: the procedures that this line discipline registers with TTY.
105 * @tx_skb: If for some reason the tty's write returns lesser bytes written 104 * @tx_skb: If for some reason the tty's write returns lesser bytes written
106 * then to maintain the rest of data to be written on next instance. 105 * then to maintain the rest of data to be written on next instance.
107 * This needs to be protected, hence the lock inside wakeup func. 106 * This needs to be protected, hence the lock inside wakeup func.
@@ -132,7 +131,6 @@ extern long st_unregister(enum proto_type);
132struct st_data_s { 131struct st_data_s {
133 unsigned long st_state; 132 unsigned long st_state;
134 struct tty_struct *tty; 133 struct tty_struct *tty;
135 struct tty_ldisc_ops *ldisc_ops;
136 struct sk_buff *tx_skb; 134 struct sk_buff *tx_skb;
137#define ST_TX_SENDING 1 135#define ST_TX_SENDING 1
138#define ST_TX_WAKEUP 2 136#define ST_TX_WAKEUP 2