diff options
| author | Ralf Baechle <ralf@linux-mips.org> | 2007-02-20 16:57:45 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-20 20:10:12 -0500 |
| commit | 7b8f850bebe093e37d283ed791039b39fa241e6d (patch) | |
| tree | 5ecd31dda2658366a9e7feb4c8c6c95e01a57caf /include/linux/sunrpc | |
| parent | e696268a73f7f59a333624f9abf8ffc9412ee64c (diff) | |
[PATCH] Fix build errors if bitop functions are do {} while macros
If one of clear_bit, change_bit or set_bit is defined as a do { } while (0)
function usage of these functions in parenthesis like
(foo_bit(23, &var))
while be expaned to something like
(do { ... } while (0)}).
resulting in a build error. This patch removes the useless parenthesis.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/sunrpc')
| -rw-r--r-- | include/linux/sunrpc/sched.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/include/linux/sunrpc/sched.h b/include/linux/sunrpc/sched.h index de9fc576fa1c..3069ecca0129 100644 --- a/include/linux/sunrpc/sched.h +++ b/include/linux/sunrpc/sched.h | |||
| @@ -150,10 +150,10 @@ struct rpc_call_ops { | |||
| 150 | #define RPC_TASK_HAS_TIMER 3 | 150 | #define RPC_TASK_HAS_TIMER 3 |
| 151 | #define RPC_TASK_ACTIVE 4 | 151 | #define RPC_TASK_ACTIVE 4 |
| 152 | 152 | ||
| 153 | #define RPC_IS_RUNNING(t) (test_bit(RPC_TASK_RUNNING, &(t)->tk_runstate)) | 153 | #define RPC_IS_RUNNING(t) test_bit(RPC_TASK_RUNNING, &(t)->tk_runstate) |
| 154 | #define rpc_set_running(t) (set_bit(RPC_TASK_RUNNING, &(t)->tk_runstate)) | 154 | #define rpc_set_running(t) set_bit(RPC_TASK_RUNNING, &(t)->tk_runstate) |
| 155 | #define rpc_test_and_set_running(t) \ | 155 | #define rpc_test_and_set_running(t) \ |
| 156 | (test_and_set_bit(RPC_TASK_RUNNING, &(t)->tk_runstate)) | 156 | test_and_set_bit(RPC_TASK_RUNNING, &(t)->tk_runstate) |
| 157 | #define rpc_clear_running(t) \ | 157 | #define rpc_clear_running(t) \ |
| 158 | do { \ | 158 | do { \ |
| 159 | smp_mb__before_clear_bit(); \ | 159 | smp_mb__before_clear_bit(); \ |
| @@ -161,8 +161,8 @@ struct rpc_call_ops { | |||
| 161 | smp_mb__after_clear_bit(); \ | 161 | smp_mb__after_clear_bit(); \ |
| 162 | } while (0) | 162 | } while (0) |
| 163 | 163 | ||
| 164 | #define RPC_IS_QUEUED(t) (test_bit(RPC_TASK_QUEUED, &(t)->tk_runstate)) | 164 | #define RPC_IS_QUEUED(t) test_bit(RPC_TASK_QUEUED, &(t)->tk_runstate) |
| 165 | #define rpc_set_queued(t) (set_bit(RPC_TASK_QUEUED, &(t)->tk_runstate)) | 165 | #define rpc_set_queued(t) set_bit(RPC_TASK_QUEUED, &(t)->tk_runstate) |
| 166 | #define rpc_clear_queued(t) \ | 166 | #define rpc_clear_queued(t) \ |
| 167 | do { \ | 167 | do { \ |
| 168 | smp_mb__before_clear_bit(); \ | 168 | smp_mb__before_clear_bit(); \ |
| @@ -179,7 +179,7 @@ struct rpc_call_ops { | |||
| 179 | smp_mb__after_clear_bit(); \ | 179 | smp_mb__after_clear_bit(); \ |
| 180 | } while (0) | 180 | } while (0) |
| 181 | 181 | ||
| 182 | #define RPC_IS_ACTIVATED(t) (test_bit(RPC_TASK_ACTIVE, &(t)->tk_runstate)) | 182 | #define RPC_IS_ACTIVATED(t) test_bit(RPC_TASK_ACTIVE, &(t)->tk_runstate) |
| 183 | 183 | ||
| 184 | /* | 184 | /* |
| 185 | * Task priorities. | 185 | * Task priorities. |
