diff options
author | Hans-Peter Nilsson <hans-peter.nilsson@axis.com> | 2007-02-12 03:52:45 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-12 12:48:31 -0500 |
commit | 0ffa0285052607513a29f529ddb5061c907fd8a6 (patch) | |
tree | d7072494d6d8005c60d42c1c841628c7d486dd9a /include/linux/spi/spi.h | |
parent | 7f8c7619ea1ff5ab8e0b08c8120d629834ef4253 (diff) |
[PATCH] SPI cleanup() method param becomes non-const
I'd like to assign NULL to kfree()d members of a structure. I can't do
that without ugly casting (see the PXA patch) when the structure pointed to
is const-qualified. I don't really see a reason why the cleanup method
isn't allowed to alter the object it should clean up. :-)
No, I didn't test the PXA patch, but I verified that the NULL-assignment
doesn't stop me from doing rmmod/insmodding my own spi_bitbang-based
driver.
Signed-off-by: Hans-Peter Nilsson <hp@axis.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/spi/spi.h')
-rw-r--r-- | include/linux/spi/spi.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index 851b25d6e82b..9d8d63109a8f 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h | |||
@@ -220,7 +220,7 @@ struct spi_master { | |||
220 | struct spi_message *mesg); | 220 | struct spi_message *mesg); |
221 | 221 | ||
222 | /* called on release() to free memory provided by spi_master */ | 222 | /* called on release() to free memory provided by spi_master */ |
223 | void (*cleanup)(const struct spi_device *spi); | 223 | void (*cleanup)(struct spi_device *spi); |
224 | }; | 224 | }; |
225 | 225 | ||
226 | static inline void *spi_master_get_devdata(struct spi_master *master) | 226 | static inline void *spi_master_get_devdata(struct spi_master *master) |