diff options
author | Jiri Slaby <jslaby@suse.cz> | 2012-03-05 08:52:17 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-03-08 15:27:57 -0500 |
commit | 964105b501071e8a0e9feb1d0e4b3e46508bc38e (patch) | |
tree | e312158b9f0ffdb4c6ad46d554593b70e3092114 /include/linux/serialP.h | |
parent | d852256389f1bcf506710ea5de77debde40013b9 (diff) |
TTY: simserial, remove support of shared interrupts
It never worked there. The ISR was never written for that kind of
stuff. So remove all that crap with a hash of linked lists and pass
the pointer directly to the ISR.
BTW this answers the question there:
* I don't know exactly why they don't use the dev_id opaque data
* pointer instead of this extra lookup table
-> Because they thought they will support more devices bound to a
single interrupt w/o IRQF_SHARED. They would need exactly the hash
there.
What I don't understand is rebinding of the interrupt in the shutdown
path. They perhaps meant to do just synchronize_irq? In any case, this
is all gone and free_irq there properly.
By removing the hash we save some bits (exactly NR_IRQS * 8 bytes of
.bss and over a kilo of .text):
before:
text data bss dec hex filename
19600 320 8227 28147 6df3 ../a/ia64/arch/ia64/hp/sim/simserial.o
after:
text data bss dec hex filename
18568 320 28 18916 49e4 ../a/ia64/arch/ia64/hp/sim/simserial.o
Note that a shared interrupt could not work too. request_irq requires
data parameter to be non-NULL. So the whole IRQ_T exercise was
pointless.
Finally, this helps us remove another two members of async_struct :).
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/serialP.h')
-rw-r--r-- | include/linux/serialP.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/linux/serialP.h b/include/linux/serialP.h index 6ce488c46589..b8543f902453 100644 --- a/include/linux/serialP.h +++ b/include/linux/serialP.h | |||
@@ -56,8 +56,6 @@ struct async_struct { | |||
56 | wait_queue_head_t open_wait; | 56 | wait_queue_head_t open_wait; |
57 | wait_queue_head_t close_wait; | 57 | wait_queue_head_t close_wait; |
58 | wait_queue_head_t delta_msr_wait; | 58 | wait_queue_head_t delta_msr_wait; |
59 | struct async_struct *next_port; /* For the linked list */ | ||
60 | struct async_struct *prev_port; | ||
61 | }; | 59 | }; |
62 | 60 | ||
63 | #endif /* _LINUX_SERIAL_H */ | 61 | #endif /* _LINUX_SERIAL_H */ |