diff options
author | H. Peter Anvin <hpa@zytor.com> | 2012-03-02 13:43:49 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-03-02 14:38:15 -0500 |
commit | 5189fa19a4b2b4c3bec37c3a019d446148827717 (patch) | |
tree | 968ba4d4dea7375cfedaf5f1e22c1885a8ea003b /include/linux/regset.h | |
parent | c8e252586f8d5de906385d8cf6385fee289a825e (diff) |
regset: Return -EFAULT, not -EIO, on host-side memory fault
There is only one error code to return for a bad user-space buffer
pointer passed to a system call in the same address space as the
system call is executed, and that is EFAULT. Furthermore, the
low-level access routines, which catch most of the faults, return
EFAULT already.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@hack.frob.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/regset.h')
-rw-r--r-- | include/linux/regset.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/regset.h b/include/linux/regset.h index 5150fd16ef93..686f37327a49 100644 --- a/include/linux/regset.h +++ b/include/linux/regset.h | |||
@@ -339,7 +339,7 @@ static inline int copy_regset_to_user(struct task_struct *target, | |||
339 | return -EOPNOTSUPP; | 339 | return -EOPNOTSUPP; |
340 | 340 | ||
341 | if (!access_ok(VERIFY_WRITE, data, size)) | 341 | if (!access_ok(VERIFY_WRITE, data, size)) |
342 | return -EIO; | 342 | return -EFAULT; |
343 | 343 | ||
344 | return regset->get(target, regset, offset, size, NULL, data); | 344 | return regset->get(target, regset, offset, size, NULL, data); |
345 | } | 345 | } |
@@ -365,7 +365,7 @@ static inline int copy_regset_from_user(struct task_struct *target, | |||
365 | return -EOPNOTSUPP; | 365 | return -EOPNOTSUPP; |
366 | 366 | ||
367 | if (!access_ok(VERIFY_READ, data, size)) | 367 | if (!access_ok(VERIFY_READ, data, size)) |
368 | return -EIO; | 368 | return -EFAULT; |
369 | 369 | ||
370 | return regset->set(target, regset, offset, size, NULL, data); | 370 | return regset->set(target, regset, offset, size, NULL, data); |
371 | } | 371 | } |