diff options
author | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-07-17 17:26:15 -0400 |
---|---|---|
committer | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-09-07 01:16:58 -0400 |
commit | 65f8c95e46a1827ae8bbc52a817ea308dd7d65ae (patch) | |
tree | adc856e8b50441b055350d8f1d83e3f641c77456 /include/linux/pstore.h | |
parent | b4a871bce619dc5ca03cc6c78e1c467ceacb8e7e (diff) |
pstore/ftrace: Convert to its own enable/disable debugfs knob
With this patch we no longer reuse function tracer infrastructure, now
we register our own tracer back-end via a debugfs knob.
It's a bit more code, but that is the only downside. On the bright side we
have:
- Ability to make persistent_ram module removable (when needed, we can
move ftrace_ops struct into a module). Note that persistent_ram is still
not removable for other reasons, but with this patch it's just one
thing less to worry about;
- Pstore part is more isolated from the generic function tracer. We tried
it already by registering our own tracer in available_tracers, but that
way we're loosing ability to see the traces while we record them to
pstore. This solution is somewhere in the middle: we only register
"internal ftracer" back-end, but not the "front-end";
- When there is only pstore tracing enabled, the kernel will only write
to the pstore buffer, omitting function tracer buffer (which, of course,
still can be enabled via 'echo function > current_tracer').
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Diffstat (limited to 'include/linux/pstore.h')
-rw-r--r-- | include/linux/pstore.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/include/linux/pstore.h b/include/linux/pstore.h index c892587d9b81..ee3034a40884 100644 --- a/include/linux/pstore.h +++ b/include/linux/pstore.h | |||
@@ -64,14 +64,6 @@ struct pstore_info { | |||
64 | void *data; | 64 | void *data; |
65 | }; | 65 | }; |
66 | 66 | ||
67 | |||
68 | #ifdef CONFIG_PSTORE_FTRACE | ||
69 | extern void pstore_ftrace_call(unsigned long ip, unsigned long parent_ip); | ||
70 | #else | ||
71 | static inline void pstore_ftrace_call(unsigned long ip, unsigned long parent_ip) | ||
72 | { } | ||
73 | #endif | ||
74 | |||
75 | #ifdef CONFIG_PSTORE | 67 | #ifdef CONFIG_PSTORE |
76 | extern int pstore_register(struct pstore_info *); | 68 | extern int pstore_register(struct pstore_info *); |
77 | #else | 69 | #else |