diff options
author | Chen Gong <gong.chen@linux.intel.com> | 2011-05-16 13:58:57 -0400 |
---|---|---|
committer | Tony Luck <tony.luck@intel.com> | 2011-05-16 14:04:51 -0400 |
commit | 8d38d74b648513dd8ed8bd2b67d899208ef4e09e (patch) | |
tree | 9746a4273b2ffb68a298ce038eb196f0f65452bb /include/linux/pstore.h | |
parent | 693d92a1bbc9e42681c42ed190bd42b636ca876f (diff) |
pstore: fix one type of return value in pstore
the return type of function _read_ in pstore is size_t,
but in the callback function of _read_, the logic doesn't
consider it too much, which means if negative value (assuming
error here) is returned, it will be converted to positive because
of type casting. ssize_t is enough for this function.
Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'include/linux/pstore.h')
-rw-r--r-- | include/linux/pstore.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/pstore.h b/include/linux/pstore.h index 41977737bb7d..14ce2f5d08af 100644 --- a/include/linux/pstore.h +++ b/include/linux/pstore.h | |||
@@ -35,7 +35,7 @@ struct pstore_info { | |||
35 | struct mutex buf_mutex; /* serialize access to 'buf' */ | 35 | struct mutex buf_mutex; /* serialize access to 'buf' */ |
36 | char *buf; | 36 | char *buf; |
37 | size_t bufsize; | 37 | size_t bufsize; |
38 | size_t (*read)(u64 *id, enum pstore_type_id *type, | 38 | ssize_t (*read)(u64 *id, enum pstore_type_id *type, |
39 | struct timespec *time); | 39 | struct timespec *time); |
40 | u64 (*write)(enum pstore_type_id type, size_t size); | 40 | u64 (*write)(enum pstore_type_id type, size_t size); |
41 | int (*erase)(u64 id); | 41 | int (*erase)(u64 id); |