diff options
author | Andres Salomon <dilinger@queued.net> | 2007-12-12 14:12:56 -0500 |
---|---|---|
committer | Anton Vorontsov <cbouatmailru@gmail.com> | 2008-02-01 18:42:59 -0500 |
commit | 8efe444038a205e79b38b7ad03878824901849a8 (patch) | |
tree | af3fdf3d84059577ba86630103ae6adbb7d885a3 /include/linux/power_supply.h | |
parent | 4d24473c435c7c3ad7b43e43b70cdb16aba25443 (diff) |
power: remove POWER_SUPPLY_PROP_CAPACITY_LEVEL
The CAPACITY_LEVEL stuff defines various levels of charge; however, what
is the difference between them? What differentiates between HIGH and NORMAL,
LOW and CRITICAL, etc?
As it appears that these are fairly arbitrary, we end up making such policy
decisions in the kernel (or in hardware). This is the sort of decision that
should be made in userspace, not in the kernel.
If the hardware does not support _CAPACITY and it cannot be easily calculated,
then perhaps the driver should register a custom CAPACITY_LEVEL attribute;
however, userspace should not become accustomed to looking for such a thing,
and we should certainly not encourage drivers to provide CAPACITY_LEVEL
stubs.
The following removes support for POWER_SUPPLY_PROP_CAPACITY_LEVEL. The
OLPC battery driver is the only driver making use of this, so it's
removed from there as well.
Signed-off-by: Andres Salomon <dilinger@debian.org>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Diffstat (limited to 'include/linux/power_supply.h')
-rw-r--r-- | include/linux/power_supply.h | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h index 606c0957997f..358b38d09fe0 100644 --- a/include/linux/power_supply.h +++ b/include/linux/power_supply.h | |||
@@ -56,15 +56,6 @@ enum { | |||
56 | POWER_SUPPLY_TECHNOLOGY_NiCd, | 56 | POWER_SUPPLY_TECHNOLOGY_NiCd, |
57 | }; | 57 | }; |
58 | 58 | ||
59 | enum { | ||
60 | POWER_SUPPLY_CAPACITY_LEVEL_UNKNOWN = 0, | ||
61 | POWER_SUPPLY_CAPACITY_LEVEL_CRITICAL, | ||
62 | POWER_SUPPLY_CAPACITY_LEVEL_LOW, | ||
63 | POWER_SUPPLY_CAPACITY_LEVEL_NORMAL, | ||
64 | POWER_SUPPLY_CAPACITY_LEVEL_HIGH, | ||
65 | POWER_SUPPLY_CAPACITY_LEVEL_FULL, | ||
66 | }; | ||
67 | |||
68 | enum power_supply_property { | 59 | enum power_supply_property { |
69 | /* Properties of type `int' */ | 60 | /* Properties of type `int' */ |
70 | POWER_SUPPLY_PROP_STATUS = 0, | 61 | POWER_SUPPLY_PROP_STATUS = 0, |
@@ -91,7 +82,6 @@ enum power_supply_property { | |||
91 | POWER_SUPPLY_PROP_ENERGY_NOW, | 82 | POWER_SUPPLY_PROP_ENERGY_NOW, |
92 | POWER_SUPPLY_PROP_ENERGY_AVG, | 83 | POWER_SUPPLY_PROP_ENERGY_AVG, |
93 | POWER_SUPPLY_PROP_CAPACITY, /* in percents! */ | 84 | POWER_SUPPLY_PROP_CAPACITY, /* in percents! */ |
94 | POWER_SUPPLY_PROP_CAPACITY_LEVEL, | ||
95 | POWER_SUPPLY_PROP_TEMP, | 85 | POWER_SUPPLY_PROP_TEMP, |
96 | POWER_SUPPLY_PROP_TEMP_AMBIENT, | 86 | POWER_SUPPLY_PROP_TEMP_AMBIENT, |
97 | POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW, | 87 | POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW, |