diff options
author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2007-10-17 02:31:09 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 11:43:04 -0400 |
commit | 402b310cb6e523779149139b20f46899a890e963 (patch) | |
tree | ac97df1b8b92cfb41cac08bd3ebfb177775570dd /include/linux/pnp.h | |
parent | 9cd8047b463f213c294f756119ac353312e7a152 (diff) |
PNP: remove null pointer checks
Remove some null pointer checks. Null pointers in these areas indicate
programming errors, and I think it's better to oops immediately rather than
return an error that is easily ignored.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Adam Belay <ambx1@neo.rr.com>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/pnp.h')
-rw-r--r-- | include/linux/pnp.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/include/linux/pnp.h b/include/linux/pnp.h index 16b46aace349..664d68cb1fbd 100644 --- a/include/linux/pnp.h +++ b/include/linux/pnp.h | |||
@@ -243,11 +243,11 @@ struct pnp_fixup { | |||
243 | #define PNP_CONFIGURABLE 0x0008 | 243 | #define PNP_CONFIGURABLE 0x0008 |
244 | #define PNP_REMOVABLE 0x0010 | 244 | #define PNP_REMOVABLE 0x0010 |
245 | 245 | ||
246 | #define pnp_can_read(dev) (((dev)->protocol) && ((dev)->protocol->get) && \ | 246 | #define pnp_can_read(dev) (((dev)->protocol->get) && \ |
247 | ((dev)->capabilities & PNP_READ)) | 247 | ((dev)->capabilities & PNP_READ)) |
248 | #define pnp_can_write(dev) (((dev)->protocol) && ((dev)->protocol->set) && \ | 248 | #define pnp_can_write(dev) (((dev)->protocol->set) && \ |
249 | ((dev)->capabilities & PNP_WRITE)) | 249 | ((dev)->capabilities & PNP_WRITE)) |
250 | #define pnp_can_disable(dev) (((dev)->protocol) && ((dev)->protocol->disable) && \ | 250 | #define pnp_can_disable(dev) (((dev)->protocol->disable) && \ |
251 | ((dev)->capabilities & PNP_DISABLE)) | 251 | ((dev)->capabilities & PNP_DISABLE)) |
252 | #define pnp_can_configure(dev) ((!(dev)->active) && \ | 252 | #define pnp_can_configure(dev) ((!(dev)->active) && \ |
253 | ((dev)->capabilities & PNP_CONFIGURABLE)) | 253 | ((dev)->capabilities & PNP_CONFIGURABLE)) |