diff options
author | Peter Zijlstra <peterz@infradead.org> | 2009-12-15 13:43:11 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-12-15 14:12:20 -0500 |
commit | f13c12c634e124d5d31f912b969d542a016d6105 (patch) | |
tree | bbb5796189ba8c2755cc14880c2216862c2fc540 /include/linux/perf_event.h | |
parent | cdccc69003388665e1463003f0488cf8ce9cf9e8 (diff) |
perf_events: Fix perf_event_attr layout
The miss-alignment of bp_addr created a 32bit hole, causing
different structure packings on 32 and 64 bit machines.
Fix that by moving __reserve_2 into that hole.
Further, remove the useless struct and redundant __bp_reserve
muck.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <1260902591.8023.781.camel@laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'include/linux/perf_event.h')
-rw-r--r-- | include/linux/perf_event.h | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 64a53f74c9a9..5fcbf7d2712a 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h | |||
@@ -211,17 +211,11 @@ struct perf_event_attr { | |||
211 | __u32 wakeup_watermark; /* bytes before wakeup */ | 211 | __u32 wakeup_watermark; /* bytes before wakeup */ |
212 | }; | 212 | }; |
213 | 213 | ||
214 | struct { /* Hardware breakpoint info */ | ||
215 | __u64 bp_addr; | ||
216 | __u32 bp_type; | ||
217 | __u32 bp_len; | ||
218 | __u64 __bp_reserved_1; | ||
219 | __u64 __bp_reserved_2; | ||
220 | }; | ||
221 | |||
222 | __u32 __reserved_2; | 214 | __u32 __reserved_2; |
223 | 215 | ||
224 | __u64 __reserved_3; | 216 | __u64 bp_addr; |
217 | __u32 bp_type; | ||
218 | __u32 bp_len; | ||
225 | }; | 219 | }; |
226 | 220 | ||
227 | /* | 221 | /* |