diff options
author | Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> | 2012-10-16 03:58:10 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2012-10-24 04:01:58 -0400 |
commit | 6760bca9fd16256210f4922a3e9f067d2c7017d7 (patch) | |
tree | 66ba5e50ff9c516b929373aaae6ebae430b6bd77 /include/linux/perf_event.h | |
parent | bffd5fc26043cce33158d4e027576e79fab2f7bb (diff) |
perf, cpu hotplug: Run CPU_STARTING notifiers with irqs disabled
The CPU_STARTING notifiers are supposed to be run with irqs
disabled. But the perf_cpu_notifier() macro invokes them without
doing that. Fix it.
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: peterz@infradead.org
Cc: acme@ghostprotocols.net
Link: http://lkml.kernel.org/r/20121016075809.3572.47848.stgit@srivatsabhat.in.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'include/linux/perf_event.h')
-rw-r--r-- | include/linux/perf_event.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 2e902359aee5..06478056da03 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h | |||
@@ -803,10 +803,13 @@ static inline void perf_event_task_tick(void) { } | |||
803 | do { \ | 803 | do { \ |
804 | static struct notifier_block fn##_nb __cpuinitdata = \ | 804 | static struct notifier_block fn##_nb __cpuinitdata = \ |
805 | { .notifier_call = fn, .priority = CPU_PRI_PERF }; \ | 805 | { .notifier_call = fn, .priority = CPU_PRI_PERF }; \ |
806 | unsigned long flags; \ | ||
806 | fn(&fn##_nb, (unsigned long)CPU_UP_PREPARE, \ | 807 | fn(&fn##_nb, (unsigned long)CPU_UP_PREPARE, \ |
807 | (void *)(unsigned long)smp_processor_id()); \ | 808 | (void *)(unsigned long)smp_processor_id()); \ |
809 | local_irq_save(flags); \ | ||
808 | fn(&fn##_nb, (unsigned long)CPU_STARTING, \ | 810 | fn(&fn##_nb, (unsigned long)CPU_STARTING, \ |
809 | (void *)(unsigned long)smp_processor_id()); \ | 811 | (void *)(unsigned long)smp_processor_id()); \ |
812 | local_irq_restore(flags); \ | ||
810 | fn(&fn##_nb, (unsigned long)CPU_ONLINE, \ | 813 | fn(&fn##_nb, (unsigned long)CPU_ONLINE, \ |
811 | (void *)(unsigned long)smp_processor_id()); \ | 814 | (void *)(unsigned long)smp_processor_id()); \ |
812 | register_cpu_notifier(&fn##_nb); \ | 815 | register_cpu_notifier(&fn##_nb); \ |