aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/page-flags.h
diff options
context:
space:
mode:
authorDean Nelson <dnelson@redhat.com>2012-03-21 19:34:05 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2012-03-21 20:54:58 -0400
commit385de35722c9a22917e7bc5e63cd83a8cffa5ecd (patch)
tree41ae2e23e096d189cdf614cf1eaf0c8f9ddeeb3b /include/linux/page-flags.h
parent6d9d88d07e132259c35f9493b15429e19198489c (diff)
thp: allow a hwpoisoned head page to be put back to LRU
Andrea Arcangeli pointed out to me that a check in __memory_failure() which was intended to prevent THP tail pages from being checked for the absence of the PG_lru flag (something that is always the case), was also preventing THP head pages from being checked. A THP head page could actually benefit from the call to shake_page() by ending up being put back to a LRU, provided it had been waiting in a pagevec array. Andrea suggested that the "!PageTransCompound(p)" in the if-statement should be replaced by a "!PageTransTail(p)", thus allowing THP head pages to be checked and possibly shaken. Signed-off-by: Dean Nelson <dnelson@redhat.com> Cc: Jin Dongming <jin.dongming@np.css.fujitsu.com> Reviewed-by: Andrea Arcangeli <aarcange@redhat.com> Cc: Andi Kleen <andi@firstfloor.org> Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/page-flags.h')
-rw-r--r--include/linux/page-flags.h20
1 files changed, 20 insertions, 0 deletions
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index e90a673be67e..6b25758e028e 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -414,11 +414,26 @@ static inline int PageTransHuge(struct page *page)
414 return PageHead(page); 414 return PageHead(page);
415} 415}
416 416
417/*
418 * PageTransCompound returns true for both transparent huge pages
419 * and hugetlbfs pages, so it should only be called when it's known
420 * that hugetlbfs pages aren't involved.
421 */
417static inline int PageTransCompound(struct page *page) 422static inline int PageTransCompound(struct page *page)
418{ 423{
419 return PageCompound(page); 424 return PageCompound(page);
420} 425}
421 426
427/*
428 * PageTransTail returns true for both transparent huge pages
429 * and hugetlbfs pages, so it should only be called when it's known
430 * that hugetlbfs pages aren't involved.
431 */
432static inline int PageTransTail(struct page *page)
433{
434 return PageTail(page);
435}
436
422#else 437#else
423 438
424static inline int PageTransHuge(struct page *page) 439static inline int PageTransHuge(struct page *page)
@@ -430,6 +445,11 @@ static inline int PageTransCompound(struct page *page)
430{ 445{
431 return 0; 446 return 0;
432} 447}
448
449static inline int PageTransTail(struct page *page)
450{
451 return 0;
452}
433#endif 453#endif
434 454
435#ifdef CONFIG_MMU 455#ifdef CONFIG_MMU