aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/netdevice.h
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2012-09-12 23:12:19 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-09-17 09:08:30 -0400
commitb004ff4972e2a42aa4512c90cc6a9e4dc1bb36b6 (patch)
tree13d68f77aeb0db8cf32ff81f7fc6931640c13f70 /include/linux/netdevice.h
parent798efc60e4276825df34af0e91ecbe0781237834 (diff)
netdev_printk/dynamic_netdev_dbg: Directly call printk_emit
A lot of stack is used in recursive printks with %pV. Using multiple levels of %pV (a logging function with %pV that calls another logging function with %pV) can consume more stack than necessary. Avoid excessive stack use by not calling dev_printk from netdev_printk and dynamic_netdev_dbg. Duplicate the logic and form of dev_printk instead. Make __netdev_printk static. Remove EXPORT_SYMBOL(__netdev_printk) Whitespace and brace style neatening. Signed-off-by: Joe Perches <joe@perches.com> Acked-by: David S. Miller <davem@davemloft.net> Tested-by: Jim Cromie <jim.cromie@gmail.com> Acked-by: Jason Baron <jbaron@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/netdevice.h')
-rw-r--r--include/linux/netdevice.h3
1 files changed, 0 insertions, 3 deletions
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 59dc05f38247..5f49cc0a107e 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2720,9 +2720,6 @@ static inline const char *netdev_name(const struct net_device *dev)
2720 return dev->name; 2720 return dev->name;
2721} 2721}
2722 2722
2723extern int __netdev_printk(const char *level, const struct net_device *dev,
2724 struct va_format *vaf);
2725
2726extern __printf(3, 4) 2723extern __printf(3, 4)
2727int netdev_printk(const char *level, const struct net_device *dev, 2724int netdev_printk(const char *level, const struct net_device *dev,
2728 const char *format, ...); 2725 const char *format, ...);