diff options
author | Yijing Wang <wangyijing@huawei.com> | 2014-10-26 22:44:37 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-11-11 17:14:30 -0500 |
commit | 03f56e42d03eb7d0a47e40e9ae72a3ac0afeff08 (patch) | |
tree | 566745f2b5cfd29a9c56fe53a6449aa9f0dc6e01 /include/linux/msi.h | |
parent | 38737d82f9f0168955f9944c3f8bd3bb262c7e88 (diff) |
Revert "PCI: Add x86_msi.msi_mask_irq() and msix_mask_irq()"
The problem fixed by 0e4ccb1505a9 ("PCI: Add x86_msi.msi_mask_irq() and
msix_mask_irq()") has been fixed in a simpler way by a previous commit
("PCI/MSI: Add pci_msi_ignore_mask to prevent writes to MSI/MSI-X Mask
Bits").
The msi_mask_irq() and msix_mask_irq() x86_msi_ops added by 0e4ccb1505a9
are no longer needed, so revert the commit.
default_msi_mask_irq() and default_msix_mask_irq() were added by
0e4ccb1505a9 and are still used by s390, so keep them for now.
[bhelgaas: changelog]
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: David Vrabel <david.vrabel@citrix.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: xen-devel@lists.xenproject.org
Diffstat (limited to 'include/linux/msi.h')
-rw-r--r-- | include/linux/msi.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/include/linux/msi.h b/include/linux/msi.h index 86dc501a1534..f6630a53be70 100644 --- a/include/linux/msi.h +++ b/include/linux/msi.h | |||
@@ -22,6 +22,8 @@ void __write_msi_msg(struct msi_desc *entry, struct msi_msg *msg); | |||
22 | void read_msi_msg(unsigned int irq, struct msi_msg *msg); | 22 | void read_msi_msg(unsigned int irq, struct msi_msg *msg); |
23 | void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg); | 23 | void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg); |
24 | void write_msi_msg(unsigned int irq, struct msi_msg *msg); | 24 | void write_msi_msg(unsigned int irq, struct msi_msg *msg); |
25 | u32 __msix_mask_irq(struct msi_desc *desc, u32 flag); | ||
26 | u32 __msi_mask_irq(struct msi_desc *desc, u32 mask, u32 flag); | ||
25 | 27 | ||
26 | struct msi_desc { | 28 | struct msi_desc { |
27 | struct { | 29 | struct { |
@@ -62,8 +64,8 @@ void arch_restore_msi_irqs(struct pci_dev *dev); | |||
62 | 64 | ||
63 | void default_teardown_msi_irqs(struct pci_dev *dev); | 65 | void default_teardown_msi_irqs(struct pci_dev *dev); |
64 | void default_restore_msi_irqs(struct pci_dev *dev); | 66 | void default_restore_msi_irqs(struct pci_dev *dev); |
65 | u32 default_msi_mask_irq(struct msi_desc *desc, u32 mask, u32 flag); | 67 | #define default_msi_mask_irq __msi_mask_irq |
66 | u32 default_msix_mask_irq(struct msi_desc *desc, u32 flag); | 68 | #define default_msix_mask_irq __msix_mask_irq |
67 | 69 | ||
68 | struct msi_chip { | 70 | struct msi_chip { |
69 | struct module *owner; | 71 | struct module *owner; |