diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-11-20 17:41:47 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-11-20 17:41:47 -0500 |
commit | 8b2e9b712f6139df9c754af0d67fecc4bbc88545 (patch) | |
tree | 4260126ffc11a2e60d92f3f9304bc2ea02516332 /include/linux/mm.h | |
parent | b5898cd057001336888b6aff601385b5f5e79b01 (diff) |
Revert "mm: create a separate slab for page->ptl allocation"
This reverts commit ea1e7ed33708c7a760419ff9ded0a6cb90586a50.
Al points out that while the commit *does* actually create a separate
slab for the page->ptl allocation, that slab is never actually used, and
the code continues to use kmalloc/kfree.
Damien Wyart points out that the original patch did have the conversion
to use kmem_cache_alloc/free, so it got lost somewhere on its way to me.
Revert the half-arsed attempt that didn't do anything. If we really do
want the special slab (remember: this is all relevant just for debug
builds, so it's not necessarily all that critical) we might as well redo
the patch fully.
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Kirill A Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/mm.h')
-rw-r--r-- | include/linux/mm.h | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/include/linux/mm.h b/include/linux/mm.h index 0548eb201e05..1cedd000cf29 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h | |||
@@ -1318,7 +1318,6 @@ static inline pmd_t *pmd_alloc(struct mm_struct *mm, pud_t *pud, unsigned long a | |||
1318 | 1318 | ||
1319 | #if USE_SPLIT_PTE_PTLOCKS | 1319 | #if USE_SPLIT_PTE_PTLOCKS |
1320 | #if BLOATED_SPINLOCKS | 1320 | #if BLOATED_SPINLOCKS |
1321 | void __init ptlock_cache_init(void); | ||
1322 | extern bool ptlock_alloc(struct page *page); | 1321 | extern bool ptlock_alloc(struct page *page); |
1323 | extern void ptlock_free(struct page *page); | 1322 | extern void ptlock_free(struct page *page); |
1324 | 1323 | ||
@@ -1327,7 +1326,6 @@ static inline spinlock_t *ptlock_ptr(struct page *page) | |||
1327 | return page->ptl; | 1326 | return page->ptl; |
1328 | } | 1327 | } |
1329 | #else /* BLOATED_SPINLOCKS */ | 1328 | #else /* BLOATED_SPINLOCKS */ |
1330 | static inline void ptlock_cache_init(void) {} | ||
1331 | static inline bool ptlock_alloc(struct page *page) | 1329 | static inline bool ptlock_alloc(struct page *page) |
1332 | { | 1330 | { |
1333 | return true; | 1331 | return true; |
@@ -1380,17 +1378,10 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) | |||
1380 | { | 1378 | { |
1381 | return &mm->page_table_lock; | 1379 | return &mm->page_table_lock; |
1382 | } | 1380 | } |
1383 | static inline void ptlock_cache_init(void) {} | ||
1384 | static inline bool ptlock_init(struct page *page) { return true; } | 1381 | static inline bool ptlock_init(struct page *page) { return true; } |
1385 | static inline void pte_lock_deinit(struct page *page) {} | 1382 | static inline void pte_lock_deinit(struct page *page) {} |
1386 | #endif /* USE_SPLIT_PTE_PTLOCKS */ | 1383 | #endif /* USE_SPLIT_PTE_PTLOCKS */ |
1387 | 1384 | ||
1388 | static inline void pgtable_init(void) | ||
1389 | { | ||
1390 | ptlock_cache_init(); | ||
1391 | pgtable_cache_init(); | ||
1392 | } | ||
1393 | |||
1394 | static inline bool pgtable_page_ctor(struct page *page) | 1385 | static inline bool pgtable_page_ctor(struct page *page) |
1395 | { | 1386 | { |
1396 | inc_zone_page_state(page, NR_PAGETABLE); | 1387 | inc_zone_page_state(page, NR_PAGETABLE); |