aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/linkage.h
diff options
context:
space:
mode:
authorVasiliy Kulikov <segoon@openwall.com>2010-11-14 02:06:08 -0500
committerDavid S. Miller <davem@davemloft.net>2010-11-17 15:27:46 -0500
commitdda0b38692a7298f433b92b1329867b1ecabb4bb (patch)
tree87e070e4d51fe128214c838f534afe1c28178f19 /include/linux/linkage.h
parent9ea19481db31d614f729f346bdcf28e4e60ff14a (diff)
net: ipv4: tcp_probe: cleanup snprintf() use
snprintf() returns number of bytes that were copied if there is no overflow. This code uses return value as number of copied bytes. Theoretically format string '%lu.%09lu %pI4:%u %pI4:%u %d %#x %#x %u %u %u %u\n' may be expanded up to 163 bytes. In reality tv.tv_sec is just few bytes instead of 20, 2 ports are just 5 bytes each instead of 10, length is 5 bytes instead of 10. The rest is an unstrusted input. Theoretically if tv_sec is big then copy_to_user() would overflow tbuf. tbuf was increased to fit in 163 bytes. snprintf() is used to follow return value semantic. Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/linkage.h')
0 files changed, 0 insertions, 0 deletions