aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/libata.h
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2008-04-07 09:47:20 -0400
committerJeff Garzik <jgarzik@redhat.com>2008-04-17 15:44:23 -0400
commit22183bf569c8600ff414ac25f23134044e0ef453 (patch)
tree1dea79cdbe439637477e1c4214b600b6823cb866 /include/linux/libata.h
parent305d2a1ab137d11d573319c315748a87060fe82d (diff)
libata: add qc_fill_rtf port operation
On command completion, ata_qc_complete() directly called ops->tf_read to fill qc->result_tf. This patch adds ops->qc_fill_rtf to replace hardcoded ops->tf_read usage. ata_sff_qc_fill_rtf() which uses ops->tf_read to fill result_tf is implemented and set in ata_base_port_ops and other ops tables which don't inherit from ata_base_port_ops, so this patch doesn't introduce any behavior change. ops->qc_fill_rtf() is similar to ops->sff_tf_read() but can only be called when a command finishes. As some non-SFF controllers don't have TF registers defined unless they're associated with in-flight commands, this limited operation makes life easier for those drivers and help lifting SFF assumptions from libata core layer. Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'include/linux/libata.h')
-rw-r--r--include/linux/libata.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 2b5a0b77e179..bb4200d42f0d 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -715,6 +715,7 @@ struct ata_port_operations {
715 int (*check_atapi_dma)(struct ata_queued_cmd *qc); 715 int (*check_atapi_dma)(struct ata_queued_cmd *qc);
716 void (*qc_prep)(struct ata_queued_cmd *qc); 716 void (*qc_prep)(struct ata_queued_cmd *qc);
717 unsigned int (*qc_issue)(struct ata_queued_cmd *qc); 717 unsigned int (*qc_issue)(struct ata_queued_cmd *qc);
718 bool (*qc_fill_rtf)(struct ata_queued_cmd *qc);
718 719
719 /* 720 /*
720 * Configuration and exception handling 721 * Configuration and exception handling
@@ -1385,6 +1386,7 @@ extern void ata_sff_irq_clear(struct ata_port *ap);
1385extern int ata_sff_hsm_move(struct ata_port *ap, struct ata_queued_cmd *qc, 1386extern int ata_sff_hsm_move(struct ata_port *ap, struct ata_queued_cmd *qc,
1386 u8 status, int in_wq); 1387 u8 status, int in_wq);
1387extern unsigned int ata_sff_qc_issue(struct ata_queued_cmd *qc); 1388extern unsigned int ata_sff_qc_issue(struct ata_queued_cmd *qc);
1389extern bool ata_sff_qc_fill_rtf(struct ata_queued_cmd *qc);
1388extern unsigned int ata_sff_host_intr(struct ata_port *ap, 1390extern unsigned int ata_sff_host_intr(struct ata_port *ap,
1389 struct ata_queued_cmd *qc); 1391 struct ata_queued_cmd *qc);
1390extern irqreturn_t ata_sff_interrupt(int irq, void *dev_instance); 1392extern irqreturn_t ata_sff_interrupt(int irq, void *dev_instance);